svn commit: samba r21513 - in branches/SAMBA_4_0/source/scripting/libjs: .

[simo]

On Sat, 2007-02-24 at 08:02 +1100, Andrew Bartlett wrote:
> On Fri, 2007-02-23 at 08:22 -0500, simo wrote:
> > On Fri, 2007-02-23 at 10:04 +0000, abartlet at samba.org wrote:
> > > Author: abartlet
> > > Date: 2007-02-23 10:04:20 +0000 (Fri, 23 Feb 2007)
> > > New Revision: 21513
> > > 
> > > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=21513
> > > 
> > > Log:
> > > I don't know how long this has been wrong, but fix this up so we can
> > > re-provision (as is required for the TEST_LDAP=yes version of make
> > > test).
> > 
> > Less than a week I suppose, I think it is part of my rewrite of the ejs
> > interface to ldb :-/
> > Strange I didn't catch this, thanks!
> 
> We need a way to reconfigure smbd during the test run.  That should
> allow us to run a normal test, then run some tests of the LDAP stuff,
> then run some tests with your shares.ldb.  

I agree.

> Then 'make test' would have caught this.

Yes, there are so many things in samba4 and samba3 that are not tested
by default ...

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org