svn commit: samba r21461 - in branches/SAMBA_3_0/source/smbd: .

[vlendec at samba.org]

Author: vlendec
Date: 2007-02-20 12:16:20 +0000 (Tue, 20 Feb 2007)
New Revision: 21461

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=21461

Log:
Not strictly necessary, as data_blob() panics if it can't allocate. But I'd
see this as a design flaw in data_blob() and it made me look in that routine.

Jeremy, revert or merge please :-)

Volker

Modified:
   branches/SAMBA_3_0/source/smbd/sesssetup.c


Changeset:
Modified: branches/SAMBA_3_0/source/smbd/sesssetup.c
===================================================================
--- branches/SAMBA_3_0/source/smbd/sesssetup.c	2007-02-20 06:22:20 UTC (rev 21460)
+++ branches/SAMBA_3_0/source/smbd/sesssetup.c	2007-02-20 12:16:20 UTC (rev 21461)
@@ -828,6 +828,10 @@
 	}
 	pad->needed_len = needed_len - pblob->length;
 	pad->partial_data = data_blob(pblob->data, pblob->length);
+	if (pad->partial_data.data == NULL) {
+		SAFE_FREE(pad);
+		return NT_STATUS_NO_MEMORY;
+	}
 	pad->smbpid = smbpid;
 	pad->vuid = vuid;
 	DLIST_ADD(pd_list, pad);