Rev 11491: Run all NDR tests in the buildfarm,
import some functions from Samba3's IDL. in
file:///home/jelmer/bzr.samba/SAMBA_4_0/
Jelmer Vernooij
jelmer at samba.org
Fri Feb 16 15:11:32 GMT 2007
At file:///home/jelmer/bzr.samba/SAMBA_4_0/
------------------------------------------------------------
revno: 11491
revision-id: jelmer at samba.org-20070216151123-m8lw5r1ebhymw8ba
parent: svn-v2:21384 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0
committer: Jelmer Vernooij <jelmer at samba.org>
branch nick: SAMBA_4_0
timestamp: Fri 2007-02-16 16:11:23 +0100
message:
Run all NDR tests in the buildfarm, import some functions from Samba3's IDL.
removed:
source/torture/local/ndr.c svn-v2:12584 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0-source%2ftorture%2flocal%2fndr.c
modified:
source/lib/registry/reg_backend_rpc.c svn-v2:4132 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0-source%2flib%2fregistry%2freg_backend_rpc.c
source/librpc/idl/winreg.idl svn-v2:6 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0-source%2flibrpc%2fidl%2fwinreg.idl
source/torture/config.mk svn-v2:860 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0-source%2ftorture%2fconfig.mk
source/torture/local/config.mk svn-v2:12008 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0-source%2ftorture%2flocal%2fconfig.mk
source/torture/local/local.c svn-v2:16333 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0-source%2ftorture%2flocal%2flocal.c
source/torture/ndr/ndr.c svn-v2:21347 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0-source%2ftorture%2fndr%2fndr.c
source/torture/ndr/winreg.c svn-v2:21347 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0-source%2ftorture%2fndr%2fwinreg.c
source/torture/rpc/winreg.c svn-v2:6 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0-source%2ftorture%2frpc%2fwinreg.c
=== removed file 'source/torture/local/ndr.c'
--- a/source/torture/local/ndr.c 2007-01-22 18:24:24 +0000
+++ b/source/torture/local/ndr.c 1970-01-01 00:00:00 +0000
@@ -1,212 +0,0 @@
-/*
- Unix SMB/CIFS implementation.
- test suite for basic ndr functions
-
- Copyright (C) Jelmer Vernooij 2005
-
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation; either version 2 of the License, or
- (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
-
- You should have received a copy of the GNU General Public License
- along with this program; if not, write to the Free Software
- Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-*/
-
-#include "includes.h"
-#include "torture/torture.h"
-#include "librpc/ndr/libndr.h"
-
-static bool test_check_string_terminator(struct torture_context *tctx)
-{
- struct ndr_pull *ndr;
- DATA_BLOB blob;
- TALLOC_CTX *mem_ctx = tctx;
-
- /* Simple test */
- blob = strhex_to_data_blob("0000");
-
- ndr = ndr_pull_init_blob(&blob, mem_ctx);
-
- torture_assert_ntstatus_ok(tctx, ndr_check_string_terminator(ndr, 1, 2),
- "simple check_string_terminator test failed");
-
- torture_assert(tctx, ndr->offset == 0,
- "check_string_terminator did not reset offset");
-
- if (NT_STATUS_IS_OK(ndr_check_string_terminator(ndr, 1, 3))) {
- torture_fail(tctx, "check_string_terminator checked beyond string boundaries");
- }
-
- torture_assert(tctx, ndr->offset == 0,
- "check_string_terminator did not reset offset");
-
- talloc_free(ndr);
-
- blob = strhex_to_data_blob("11220000");
- ndr = ndr_pull_init_blob(&blob, mem_ctx);
-
- torture_assert_ntstatus_ok(tctx,
- ndr_check_string_terminator(ndr, 4, 1),
- "check_string_terminator failed to recognize terminator");
-
- torture_assert_ntstatus_ok(tctx,
- ndr_check_string_terminator(ndr, 3, 1),
- "check_string_terminator failed to recognize terminator");
-
- if (NT_STATUS_IS_OK(ndr_check_string_terminator(ndr, 2, 1))) {
- torture_fail(tctx,
- "check_string_terminator erroneously reported terminator");
- }
-
- torture_assert(tctx, ndr->offset == 0,
- "check_string_terminator did not reset offset");
- return true;
-}
-
-static bool test_guid_from_string_valid(struct torture_context *tctx)
-{
- /* FIXME */
- return true;
-}
-
-static bool test_guid_from_string_null(struct torture_context *tctx)
-{
- struct GUID guid;
- torture_assert_ntstatus_equal(tctx, NT_STATUS_INVALID_PARAMETER,
- GUID_from_string(NULL, &guid),
- "NULL failed");
- return true;
-}
-
-static bool test_guid_from_string_invalid(struct torture_context *tctx)
-{
- struct GUID g1;
- torture_assert_ntstatus_equal(tctx, NT_STATUS_INVALID_PARAMETER,
- GUID_from_string("bla", &g1),
- "parameter not invalid");
- return true;
-}
-
-static bool test_guid_from_string(struct torture_context *tctx)
-{
- struct GUID g1, exp;
- torture_assert_ntstatus_ok(tctx,
- GUID_from_string("00000001-0002-0003-0405-060708090a0b", &g1),
- "invalid return code");
- exp.time_low = 1;
- exp.time_mid = 2;
- exp.time_hi_and_version = 3;
- exp.clock_seq[0] = 4;
- exp.clock_seq[1] = 5;
- exp.node[0] = 6;
- exp.node[1] = 7;
- exp.node[2] = 8;
- exp.node[3] = 9;
- exp.node[4] = 10;
- exp.node[5] = 11;
- torture_assert(tctx, GUID_equal(&g1, &exp), "UUID parsed incorrectly");
- torture_assert_ntstatus_ok(tctx,
- GUID_from_string("{00000001-0002-0003-0405-060708090a0b}", &g1),
- "invalid return code");
- torture_assert(tctx, GUID_equal(&g1, &exp), "UUID parsed incorrectly");
-
- return true;
-}
-
-static bool test_guid_string_valid(struct torture_context *tctx)
-{
- struct GUID g;
- g.time_low = 1;
- g.time_mid = 2;
- g.time_hi_and_version = 3;
- g.clock_seq[0] = 4;
- g.clock_seq[1] = 5;
- g.node[0] = 6;
- g.node[1] = 7;
- g.node[2] = 8;
- g.node[3] = 9;
- g.node[4] = 10;
- g.node[5] = 11;
- torture_assert_str_equal(tctx, "00000001-0002-0003-0405-060708090a0b", GUID_string(tctx, &g),
- "parsing guid failed");
- return true;
-}
-
-static bool test_guid_string2_valid(struct torture_context *tctx)
-{
- struct GUID g;
- g.time_low = 1;
- g.time_mid = 2;
- g.time_hi_and_version = 3;
- g.clock_seq[0] = 4;
- g.clock_seq[1] = 5;
- g.node[0] = 6;
- g.node[1] = 7;
- g.node[2] = 8;
- g.node[3] = 9;
- g.node[4] = 10;
- g.node[5] = 11;
- torture_assert_str_equal(tctx, "{00000001-0002-0003-0405-060708090a0b}", GUID_string2(tctx, &g),
- "parsing guid failed");
- return true;
-}
-
-static bool test_compare_uuid(struct torture_context *tctx)
-{
- struct GUID g1, g2;
- ZERO_STRUCT(g1); ZERO_STRUCT(g2);
- torture_assert_int_equal(tctx, 0, GUID_compare(&g1, &g2),
- "GUIDs not equal");
- g1.time_low = 1;
- torture_assert_int_equal(tctx, 1, GUID_compare(&g1, &g2),
- "GUID diff invalid");
-
- g1.time_low = 10;
- torture_assert_int_equal(tctx, 10, GUID_compare(&g1, &g2),
- "GUID diff invalid");
-
- g1.time_low = 0;
- g1.clock_seq[1] = 20;
- torture_assert_int_equal(tctx, 20, GUID_compare(&g1, &g2),
- "GUID diff invalid");
- return true;
-}
-
-
-struct torture_suite *torture_local_ndr(TALLOC_CTX *mem_ctx)
-{
- struct torture_suite *suite = torture_suite_create(mem_ctx, "NDR");
-
- torture_suite_add_simple_test(suite, "string terminator",
- test_check_string_terminator);
-
- torture_suite_add_simple_test(suite, "guid_from_string_null",
- test_guid_from_string_null);
-
- torture_suite_add_simple_test(suite, "guid_from_string",
- test_guid_from_string);
-
- torture_suite_add_simple_test(suite, "guid_from_string_invalid",
- test_guid_from_string_invalid);
-
- torture_suite_add_simple_test(suite, "guid_string_valid",
- test_guid_string_valid);
-
- torture_suite_add_simple_test(suite, "guid_string2_valid",
- test_guid_string2_valid);
-
- torture_suite_add_simple_test(suite, "guid_from_string_valid",
- test_guid_from_string_valid);
-
- torture_suite_add_simple_test(suite, "compare_uuid",
- test_compare_uuid);
-
- return suite;
-}
=== modified file 'source/lib/registry/reg_backend_rpc.c'
--- a/source/lib/registry/reg_backend_rpc.c 2006-09-15 18:34:03 +0000
+++ b/source/lib/registry/reg_backend_rpc.c 2007-02-16 15:11:23 +0000
@@ -280,7 +280,8 @@
struct rpc_key_data *mykeydata = k->backend_data;
TALLOC_CTX *mem_ctx = talloc_init("query_key");
- init_winreg_String(&r.in.class_in, NULL);
+ r.in.classname = talloc(mem_ctx, struct winreg_String);
+ init_winreg_String(r.in.classname, NULL);
r.in.handle = &mykeydata->pol;
status = dcerpc_winreg_QueryInfoKey((struct dcerpc_pipe *)(k->hive->backend_data), mem_ctx, &r);
=== modified file 'source/librpc/idl/winreg.idl'
--- a/source/librpc/idl/winreg.idl 2007-02-15 21:06:33 +0000
+++ b/source/librpc/idl/winreg.idl 2007-02-16 15:11:23 +0000
@@ -148,6 +148,8 @@
[size_is(size/2),length_is(length/2),charset(UTF16)] uint16 *name;
} winreg_StringBuf;
+ /******************/
+ /* Function: 0x09 */
[public] WERROR winreg_EnumKey(
[in,ref] policy_handle *handle,
[in] uint32 enum_index,
@@ -217,7 +219,7 @@
/* Function: 0x10 */
[public] WERROR winreg_QueryInfoKey(
[in,ref] policy_handle *handle,
- [in,out,ref] winreg_String *class_in,
+ [in,out,ref] winreg_String *classname,
[out,ref] uint32 *num_subkeys,
[out,ref] uint32 *max_subkeylen,
[out,ref] uint32 *max_subkeysize,
@@ -247,11 +249,24 @@
/******************/
/* Function: 0x13 */
WERROR winreg_RestoreKey(
+ [in,ref] policy_handle *handle,
+ [in,ref] winreg_String *filename,
+ [in] uint32 flags
);
/******************/
/* Function: 0x14 */
+
+ typedef struct {
+ uint32 data_size;
+ KeySecurityData sec_data;
+ uint8 inherit;
+ } KeySecurityAttribute;
+
WERROR winreg_SaveKey(
+ [in,ref] policy_handle *handle,
+ [in,ref] winreg_String *filename,
+ [in,unique] KeySecurityAttribute *sec_attrib
);
/******************/
@@ -259,7 +274,7 @@
WERROR winreg_SetKeySecurity(
[in,ref] policy_handle *handle,
[in] winreg_AccessMask access_mask,
- [in,out,ref] KeySecurityData *sd
+ [in,ref] KeySecurityData *sd
);
/******************/
=== modified file 'source/torture/config.mk'
--- a/source/torture/config.mk 2007-02-16 12:47:08 +0000
+++ b/source/torture/config.mk 2007-02-16 15:11:23 +0000
@@ -96,9 +96,7 @@
include smb2/config.mk
-[MODULE::torture_ndr]
-SUBSYSTEM = torture
-INIT_FUNCTION = torture_ndr_init
+[SUBSYSTEM::TORTURE_NDR]
PRIVATE_PROTO_HEADER = ndr/proto.h
OBJ_FILES = ndr/ndr.o \
ndr/winreg.o \
=== modified file 'source/torture/local/config.mk'
--- a/source/torture/local/config.mk 2007-01-23 00:39:12 +0000
+++ b/source/torture/local/config.mk 2007-02-16 15:11:23 +0000
@@ -25,7 +25,6 @@
util_strlist.o \
util_file.o \
sddl.o \
- ndr.o \
tdr.o \
event.o \
local.o \
@@ -42,6 +41,7 @@
POPT_CREDENTIALS \
TORTURE_AUTH \
TORTURE_UTIL
+PRIVATE_DEPENDENCIES = TORTURE_NDR
# End SUBSYSTEM TORTURE_LOCAL
#################################
=== modified file 'source/torture/local/local.c'
--- a/source/torture/local/local.c 2007-01-23 00:39:12 +0000
+++ b/source/torture/local/local.c 2007-02-16 15:11:23 +0000
@@ -21,6 +21,8 @@
#include "includes.h"
#include "torture/torture.h"
#include "torture/local/proto.h"
+#include "torture/ndr/ndr.h"
+#include "torture/ndr/proto.h"
#include "torture/auth/proto.h"
/* ignore me */ static struct torture_suite *
=== modified file 'source/torture/ndr/ndr.c'
--- a/source/torture/ndr/ndr.c 2007-02-16 12:47:08 +0000
+++ b/source/torture/ndr/ndr.c 2007-02-16 15:11:23 +0000
@@ -84,7 +84,163 @@
return test;
}
-NTSTATUS torture_ndr_init(void)
+static bool test_check_string_terminator(struct torture_context *tctx)
+{
+ struct ndr_pull *ndr;
+ DATA_BLOB blob;
+ TALLOC_CTX *mem_ctx = tctx;
+
+ /* Simple test */
+ blob = strhex_to_data_blob("0000");
+
+ ndr = ndr_pull_init_blob(&blob, mem_ctx);
+
+ torture_assert_ntstatus_ok(tctx, ndr_check_string_terminator(ndr, 1, 2),
+ "simple check_string_terminator test failed");
+
+ torture_assert(tctx, ndr->offset == 0,
+ "check_string_terminator did not reset offset");
+
+ if (NT_STATUS_IS_OK(ndr_check_string_terminator(ndr, 1, 3))) {
+ torture_fail(tctx, "check_string_terminator checked beyond string boundaries");
+ }
+
+ torture_assert(tctx, ndr->offset == 0,
+ "check_string_terminator did not reset offset");
+
+ talloc_free(ndr);
+
+ blob = strhex_to_data_blob("11220000");
+ ndr = ndr_pull_init_blob(&blob, mem_ctx);
+
+ torture_assert_ntstatus_ok(tctx,
+ ndr_check_string_terminator(ndr, 4, 1),
+ "check_string_terminator failed to recognize terminator");
+
+ torture_assert_ntstatus_ok(tctx,
+ ndr_check_string_terminator(ndr, 3, 1),
+ "check_string_terminator failed to recognize terminator");
+
+ if (NT_STATUS_IS_OK(ndr_check_string_terminator(ndr, 2, 1))) {
+ torture_fail(tctx,
+ "check_string_terminator erroneously reported terminator");
+ }
+
+ torture_assert(tctx, ndr->offset == 0,
+ "check_string_terminator did not reset offset");
+ return true;
+}
+
+static bool test_guid_from_string_valid(struct torture_context *tctx)
+{
+ /* FIXME */
+ return true;
+}
+
+static bool test_guid_from_string_null(struct torture_context *tctx)
+{
+ struct GUID guid;
+ torture_assert_ntstatus_equal(tctx, NT_STATUS_INVALID_PARAMETER,
+ GUID_from_string(NULL, &guid),
+ "NULL failed");
+ return true;
+}
+
+static bool test_guid_from_string_invalid(struct torture_context *tctx)
+{
+ struct GUID g1;
+ torture_assert_ntstatus_equal(tctx, NT_STATUS_INVALID_PARAMETER,
+ GUID_from_string("bla", &g1),
+ "parameter not invalid");
+ return true;
+}
+
+static bool test_guid_from_string(struct torture_context *tctx)
+{
+ struct GUID g1, exp;
+ torture_assert_ntstatus_ok(tctx,
+ GUID_from_string("00000001-0002-0003-0405-060708090a0b", &g1),
+ "invalid return code");
+ exp.time_low = 1;
+ exp.time_mid = 2;
+ exp.time_hi_and_version = 3;
+ exp.clock_seq[0] = 4;
+ exp.clock_seq[1] = 5;
+ exp.node[0] = 6;
+ exp.node[1] = 7;
+ exp.node[2] = 8;
+ exp.node[3] = 9;
+ exp.node[4] = 10;
+ exp.node[5] = 11;
+ torture_assert(tctx, GUID_equal(&g1, &exp), "UUID parsed incorrectly");
+ torture_assert_ntstatus_ok(tctx,
+ GUID_from_string("{00000001-0002-0003-0405-060708090a0b}", &g1),
+ "invalid return code");
+ torture_assert(tctx, GUID_equal(&g1, &exp), "UUID parsed incorrectly");
+
+ return true;
+}
+
+static bool test_guid_string_valid(struct torture_context *tctx)
+{
+ struct GUID g;
+ g.time_low = 1;
+ g.time_mid = 2;
+ g.time_hi_and_version = 3;
+ g.clock_seq[0] = 4;
+ g.clock_seq[1] = 5;
+ g.node[0] = 6;
+ g.node[1] = 7;
+ g.node[2] = 8;
+ g.node[3] = 9;
+ g.node[4] = 10;
+ g.node[5] = 11;
+ torture_assert_str_equal(tctx, "00000001-0002-0003-0405-060708090a0b", GUID_string(tctx, &g),
+ "parsing guid failed");
+ return true;
+}
+
+static bool test_guid_string2_valid(struct torture_context *tctx)
+{
+ struct GUID g;
+ g.time_low = 1;
+ g.time_mid = 2;
+ g.time_hi_and_version = 3;
+ g.clock_seq[0] = 4;
+ g.clock_seq[1] = 5;
+ g.node[0] = 6;
+ g.node[1] = 7;
+ g.node[2] = 8;
+ g.node[3] = 9;
+ g.node[4] = 10;
+ g.node[5] = 11;
+ torture_assert_str_equal(tctx, "{00000001-0002-0003-0405-060708090a0b}", GUID_string2(tctx, &g),
+ "parsing guid failed");
+ return true;
+}
+
+static bool test_compare_uuid(struct torture_context *tctx)
+{
+ struct GUID g1, g2;
+ ZERO_STRUCT(g1); ZERO_STRUCT(g2);
+ torture_assert_int_equal(tctx, 0, GUID_compare(&g1, &g2),
+ "GUIDs not equal");
+ g1.time_low = 1;
+ torture_assert_int_equal(tctx, 1, GUID_compare(&g1, &g2),
+ "GUID diff invalid");
+
+ g1.time_low = 10;
+ torture_assert_int_equal(tctx, 10, GUID_compare(&g1, &g2),
+ "GUID diff invalid");
+
+ g1.time_low = 0;
+ g1.clock_seq[1] = 20;
+ torture_assert_int_equal(tctx, 20, GUID_compare(&g1, &g2),
+ "GUID diff invalid");
+ return true;
+}
+
+struct torture_suite *torture_local_ndr(void)
{
struct torture_suite *suite = torture_suite_create(talloc_autofree_context(), "NDR");
@@ -94,8 +250,30 @@
torture_suite_add_suite(suite, ndr_epmap_suite(suite));
torture_suite_add_suite(suite, ndr_dfs_suite(suite));
- torture_register_suite(suite);
-
- return NT_STATUS_OK;
+ torture_suite_add_simple_test(suite, "string terminator",
+ test_check_string_terminator);
+
+ torture_suite_add_simple_test(suite, "guid_from_string_null",
+ test_guid_from_string_null);
+
+ torture_suite_add_simple_test(suite, "guid_from_string",
+ test_guid_from_string);
+
+ torture_suite_add_simple_test(suite, "guid_from_string_invalid",
+ test_guid_from_string_invalid);
+
+ torture_suite_add_simple_test(suite, "guid_string_valid",
+ test_guid_string_valid);
+
+ torture_suite_add_simple_test(suite, "guid_string2_valid",
+ test_guid_string2_valid);
+
+ torture_suite_add_simple_test(suite, "guid_from_string_valid",
+ test_guid_from_string_valid);
+
+ torture_suite_add_simple_test(suite, "compare_uuid",
+ test_compare_uuid);
+
+ return suite;
}
=== modified file 'source/torture/ndr/winreg.c'
--- a/source/torture/ndr/winreg.c 2007-02-15 21:06:33 +0000
+++ b/source/torture/ndr/winreg.c 2007-02-16 15:11:23 +0000
@@ -390,7 +390,7 @@
static bool queryinfokey_in_check(struct torture_context *tctx, struct winreg_QueryInfoKey *r)
{
/* FIXME: Handle */
- torture_assert(tctx, r->in.class_in->name == NULL, "class in");
+ torture_assert(tctx, r->in.classname->name == NULL, "class in");
return true;
}
@@ -403,9 +403,9 @@
static bool queryinfokey_out_check(struct torture_context *tctx, struct winreg_QueryInfoKey *r)
{
- torture_assert(tctx, r->out.class_in != NULL, "class out");
- torture_assert(tctx, r->out.class_in->name != NULL, "class out name");
- torture_assert_str_equal(tctx, r->out.class_in->name, "", "class out name");
+ torture_assert(tctx, r->out.classname != NULL, "class out");
+ torture_assert(tctx, r->out.classname->name != NULL, "class out name");
+ torture_assert_str_equal(tctx, r->out.classname->name, "", "class out name");
torture_assert_int_equal(tctx, *r->out.num_subkeys, 0, "num subkeys");
torture_assert_int_equal(tctx, *r->out.max_subkeylen, 0, "subkey length");
torture_assert_int_equal(tctx, *r->out.max_subkeysize, 140, "subkey size");
=== modified file 'source/torture/rpc/winreg.c'
--- a/source/torture/rpc/winreg.c 2006-10-18 14:23:19 +0000
+++ b/source/torture/rpc/winreg.c 2007-02-16 15:11:23 +0000
@@ -392,7 +392,8 @@
r.out.secdescsize = &secdescsize;
r.out.last_changed_time = &last_changed_time;
- init_winreg_String(&r.in.class_in, class);
+ r.in.classname = talloc(mem_ctx, struct winreg_String);
+ init_winreg_String(r.in.classname, class);
status = dcerpc_winreg_QueryInfoKey(p, mem_ctx, &r);
More information about the samba-cvs
mailing list