svn commit: samba r21338 - in branches/SAMBA_4_0: . source/pidl/lib/Parse/Pidl/Samba3 source/pidl/tests

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Collier-Brown schrieb:
>   #warning does seem to cause diagnostics on the compilers which don't know
> what it means... is there a case where it's silently ignored and the bad
> code
> just compiles to a non-running executable?

Compilers with support for it just print a warning to stderr and compile
fine.

Compilers without port reject to compile.

Both variants are wrong in the current situation, because errors should
be reported when they are detected, so pidl should reject to compile
instead of generating code that may not be useable by the compiler.

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFF1A8tm70gjA5TCD8RApwnAKCKM6SfYT20f/1nfN9xsO4WsNC+OgCgyUTT
QQUoAoGIj7OvSKdIqnLtKMg=
=5YGZ
-----END PGP SIGNATURE-----