svn commit: samba r24698 - in branches/SAMBA_4_0/source/client: .

abartlet at samba.org abartlet at samba.org
Mon Aug 27 10:16:55 GMT 2007


Author: abartlet
Date: 2007-08-27 10:16:54 +0000 (Mon, 27 Aug 2007)
New Revision: 24698

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=24698

Log:
Patch from Andrew Kroeger <andrew at sprocks.gotdns.com> to fix Bug
#4521: smbclient crashes during tab completion when tab hit twice.

The readline magic is beyond me, but this seems to do the trick.

Andrew Bartlett

Modified:
   branches/SAMBA_4_0/source/client/client.c


Changeset:
Modified: branches/SAMBA_4_0/source/client/client.c
===================================================================
--- branches/SAMBA_4_0/source/client/client.c	2007-08-27 02:31:51 UTC (rev 24697)
+++ branches/SAMBA_4_0/source/client/client.c	2007-08-27 10:16:54 UTC (rev 24698)
@@ -2922,9 +2922,10 @@
 		return matches;
 
 cleanup:
-		while (i >= 0) {
-			free(matches[i]);
-			i--;
+		count--;
+		while (count >= 0) {
+			free(matches[count]);
+			count--;
 		}
 		free(matches);
 		return NULL;



More information about the samba-cvs mailing list