svn commit: samba r24665 - in branches/SAMBA_4_0: .
source/selftest/output
jelmer at samba.org
jelmer at samba.org
Sun Aug 26 14:07:24 GMT 2007
Author: jelmer
Date: 2007-08-26 14:07:23 +0000 (Sun, 26 Aug 2007)
New Revision: 24665
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=24665
Log:
Close file handles properly.
Modified:
branches/SAMBA_4_0/
branches/SAMBA_4_0/source/selftest/output/html.pm
Changeset:
Property changes on: branches/SAMBA_4_0
___________________________________________________________________
Name: bzr:revision-info
...skipped...
Name: bzr:revision-id:v3-trunk0
...skipped...
Modified: branches/SAMBA_4_0/source/selftest/output/html.pm
===================================================================
--- branches/SAMBA_4_0/source/selftest/output/html.pm 2007-08-26 14:03:29 UTC (rev 24664)
+++ branches/SAMBA_4_0/source/selftest/output/html.pm 2007-08-26 14:07:23 UTC (rev 24665)
@@ -5,6 +5,7 @@
@ISA = qw(Exporter);
use strict;
+use warnings;
sub new($$$$) {
my ($class, $dirname, $statistics) = @_;
@@ -48,9 +49,9 @@
my ($self, $state, $output) = @_;
unless (defined($self->{active_test})) {
- print TEST "$output<br>";
+ print TEST "$output<br/>";
} else {
- $self->{msg} .= "$output<br>";
+ $self->{msg} .= "$output<br/>";
}
}
@@ -63,17 +64,17 @@
close(TEST);
- print {$self->{INDEX}} "<tr><td><a href=\"$state->{HTMLFILE}\">$state->{NAME}</a></td><td>$state->{ENVNAME}</td>";
+ print INDEX "<tr><td><a href=\"$state->{HTMLFILE}\">$state->{NAME}</a></td><td>$state->{ENVNAME}</td>";
if ($ret == $expected_ret) {
- print {$self->{INDEX}} "<td bgcolor=\"green\">OK</td>";
+ print INDEX "<td bgcolor=\"green\">OK</td>";
} else {
- print {$self->{INDEX}} "<td bgcolor=\"red\">FAIL</td>";
+ print INDEX "<td bgcolor=\"red\">FAIL</td>";
}
- print {$self->{INDEX}} "<td>" . (time() - $state->{START_TIME}) . "</td>\n";
+ print INDEX "<td>" . (time() - $state->{START_TIME}) . "</td>\n";
- print {$self->{INDEX}} "</tr>\n";
+ print INDEX "</tr>\n";
}
sub start_test($$$)
@@ -106,11 +107,13 @@
sub summary($)
{
my ($self) = @_;
- print {$self->{INDEX}} "</table>\n";
- print {$self->{INDEX}} "FAILED ($self->{statistics}->{TESTS_UNEXPECTED_FAIL} failures and $self->{statistics}->{TESTS_ERROR} errors in $self->{statistics}->{SUITES_FAIL} testsuites)\n";
+ print INDEX "</table>\n";
+ print INDEX "FAILED ($self->{statistics}->{TESTS_UNEXPECTED_FAIL} failures and $self->{statistics}->{TESTS_ERROR} errors in $self->{statistics}->{SUITES_FAIL} testsuites)\n";
- print {$self->{INDEX}} "</body>\n";
- print {$self->{INDEX}} "</html>\n";
+ print INDEX "</body>\n";
+ print INDEX "</html>\n";
+
+ close(INDEX);
}
sub missing_env($$$)
@@ -124,7 +127,7 @@
{
my ($self, $name) = @_;
- print {$self->{INDEX}} "<tr><td>$name</td><td>N/A</td><td bgcolor=\"yellow\">SKIPPED</td><td>N/A</td></tr>\n";
+ print INDEX "<tr><td>$name</td><td>N/A</td><td bgcolor=\"yellow\">SKIPPED</td><td>N/A</td></tr>\n";
}
1;
More information about the samba-cvs
mailing list