svn commit: samba r24316 - in branches: SAMBA_3_0_25/source/rpc_server SAMBA_3_2/source/rpc_server SAMBA_3_2_0/source/rpc_server

vlendec at samba.org vlendec at samba.org
Fri Aug 10 20:03:32 GMT 2007


Author: vlendec
Date: 2007-08-10 20:03:31 +0000 (Fri, 10 Aug 2007)
New Revision: 24316

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=24316

Log:
Fix an uninitialized read

Jerry, please check this!

Thanks,

Volker

Modified:
   branches/SAMBA_3_0_25/source/rpc_server/srv_spoolss_nt.c
   branches/SAMBA_3_2/source/rpc_server/srv_spoolss_nt.c
   branches/SAMBA_3_2_0/source/rpc_server/srv_spoolss_nt.c


Changeset:
Modified: branches/SAMBA_3_0_25/source/rpc_server/srv_spoolss_nt.c
===================================================================
--- branches/SAMBA_3_0_25/source/rpc_server/srv_spoolss_nt.c	2007-08-10 16:01:47 UTC (rev 24315)
+++ branches/SAMBA_3_0_25/source/rpc_server/srv_spoolss_nt.c	2007-08-10 20:03:31 UTC (rev 24316)
@@ -2263,6 +2263,7 @@
 		*type = REG_DWORD;
 		if ( !(*data = TALLOC_ARRAY(ctx, uint8, sizeof(uint32) )) )
 			return WERR_NOMEM;
+		SIVAL(*data, 0, 0x00);
 		*needed = 0x4;
 		return WERR_OK;
 	}

Modified: branches/SAMBA_3_2/source/rpc_server/srv_spoolss_nt.c
===================================================================
--- branches/SAMBA_3_2/source/rpc_server/srv_spoolss_nt.c	2007-08-10 16:01:47 UTC (rev 24315)
+++ branches/SAMBA_3_2/source/rpc_server/srv_spoolss_nt.c	2007-08-10 20:03:31 UTC (rev 24316)
@@ -2275,6 +2275,7 @@
 		*type = REG_DWORD;
 		if ( !(*data = TALLOC_ARRAY(ctx, uint8, sizeof(uint32) )) )
 			return WERR_NOMEM;
+		SIVAL(*data, 0, 0x00);
 		*needed = 0x4;
 		return WERR_OK;
 	}

Modified: branches/SAMBA_3_2_0/source/rpc_server/srv_spoolss_nt.c
===================================================================
--- branches/SAMBA_3_2_0/source/rpc_server/srv_spoolss_nt.c	2007-08-10 16:01:47 UTC (rev 24315)
+++ branches/SAMBA_3_2_0/source/rpc_server/srv_spoolss_nt.c	2007-08-10 20:03:31 UTC (rev 24316)
@@ -2268,6 +2268,7 @@
 		*type = REG_DWORD;
 		if ( !(*data = TALLOC_ARRAY(ctx, uint8, sizeof(uint32) )) )
 			return WERR_NOMEM;
+		SIVAL(*data, 0, 0x00);
 		*needed = 0x4;
 		return WERR_OK;
 	}



More information about the samba-cvs mailing list