svn commit: samba r24248 - in branches/SAMBA_4_0/source/libcli/ldap: .

abartlet at samba.org abartlet at samba.org
Mon Aug 6 04:07:07 GMT 2007


Author: abartlet
Date: 2007-08-06 04:07:05 +0000 (Mon, 06 Aug 2007)
New Revision: 24248

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=24248

Log:
Attempt to fix bug #4830 by <mwallnoefer at yahoo.de>.  If there is no
payload to the control, we still need to inialise *value, as otherwise
we read uninitialised data later.

Andrew Bartlett

Modified:
   branches/SAMBA_4_0/source/libcli/ldap/ldap_controls.c


Changeset:
Modified: branches/SAMBA_4_0/source/libcli/ldap/ldap_controls.c
===================================================================
--- branches/SAMBA_4_0/source/libcli/ldap/ldap_controls.c	2007-08-06 03:48:56 UTC (rev 24247)
+++ branches/SAMBA_4_0/source/libcli/ldap/ldap_controls.c	2007-08-06 04:07:05 UTC (rev 24248)
@@ -1143,6 +1143,7 @@
 	ctrl->data = NULL;
 
 	if (!asn1_peek_tag(data, ASN1_OCTET_STRING)) {
+		*value = data_blob(NULL, 0);
 		goto end_tag;
 	}
 



More information about the samba-cvs mailing list