svn commit: samba r22573 - in branches: SAMBA_3_0/source/rpc_server SAMBA_3_0_25/source/rpc_server

jra at samba.org jra at samba.org
Sun Apr 29 19:20:49 GMT 2007


Author: jra
Date: 2007-04-29 19:20:48 +0000 (Sun, 29 Apr 2007)
New Revision: 22573

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22573

Log:
Fix old bug mixing free() and talloc_free()
when the add_sid_to_array_XX code was moved
from malloc to talloc. Found running valgrind
and rpcclient. Needs merging for 3.0.25 final.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c
   branches/SAMBA_3_0_25/source/rpc_server/srv_lsa_nt.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c	2007-04-29 15:24:49 UTC (rev 22572)
+++ branches/SAMBA_3_0/source/rpc_server/srv_lsa_nt.c	2007-04-29 19:20:48 UTC (rev 22573)
@@ -1502,7 +1502,7 @@
 		(*sids).ptr_sid[j] = 1;
 	}
 
-	SAFE_FREE(sid_list);
+	talloc_free(sid_list);
 
 	init_lsa_r_enum_accounts(r_u, num_entries);
 

Modified: branches/SAMBA_3_0_25/source/rpc_server/srv_lsa_nt.c
===================================================================
--- branches/SAMBA_3_0_25/source/rpc_server/srv_lsa_nt.c	2007-04-29 15:24:49 UTC (rev 22572)
+++ branches/SAMBA_3_0_25/source/rpc_server/srv_lsa_nt.c	2007-04-29 19:20:48 UTC (rev 22573)
@@ -1505,7 +1505,7 @@
 		(*sids).ptr_sid[j] = 1;
 	}
 
-	SAFE_FREE(sid_list);
+	talloc_free(sid_list);
 
 	init_lsa_r_enum_accounts(r_u, num_entries);
 



More information about the samba-cvs mailing list