svn commit: samba r22202 - in branches/SAMBA_3_0/source/nsswitch: .

[Jeremy Allison]

On Fri, Apr 13, 2007 at 02:36:51PM +1000, tridge at samba.org wrote:
> 
> That wasn't my question. I don't doubt that it is possible to get a
> corrupt tdb file. What I am asking is if you have seen a corrupt tdb
> file that causes a 'wild pointer', and presumably a crash in the tdb
> code that is reading the file.
> 
> The patch you applied implied that you thought we might get a file
> like that, and that disabling MMAP would avoid the segv. I shouldn't
> matter if you have the contents of /dev/random in a tdb file, it
> should not segv, no matter if using mmap or not (there is an exception
> to this, where the file is truncated out from under a running program
> accessing tdb via mmap - that is arguably a kernel bug, and is not
> relevant to the situation you are trying to fix).
> 
> So if you do have a tdb file that when read using mmap causes a crash,
> please give me a copy. It implies that we have a real bug.

Ah, *now* I see - sorry. I didn't get it. No, I don't have a file
like that - I haven't seen a wild pointer crash in the tdb code
itself for a long long time :-). I'm thinking of the somewhat
less robust code that is processing the tdb output data :-).

Although some rather woolley thinking on my part did rather
confuse the two :-).

I will test this code with the contents of /dev/random
though (prepended with a valid tdb header of course :-).

Jeremy.