Rev 11785: More refactoring. in
file:///home/jelmer/bzr.samba/SAMBA_4_0/
Jelmer Vernooij
jelmer at samba.org
Wed Apr 4 13:22:57 GMT 2007
At file:///home/jelmer/bzr.samba/SAMBA_4_0/
------------------------------------------------------------
revno: 11785
revision-id: jelmer at samba.org-20070404132246-su7ilvxviyo3fu16
parent: svn-v2:22072 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0
committer: Jelmer Vernooij <jelmer at samba.org>
branch nick: SAMBA_4_0
timestamp: Wed 2007-04-04 15:22:46 +0200
message:
More refactoring.
modified:
source/script/tests/Samba3.pm svn-v2:21909 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0-source%2fscript%2ftests%2fSamba3.pm
source/script/tests/Samba4.pm svn-v2:21707 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0-source%2fscript%2ftests%2fSamba4.pm
source/script/tests/selftest.pl svn-v2:20693 at 0c0555d6-39d7-0310-84fc-f1cc0bd64818-branches%2fSAMBA_4_0-source%2fscript%2ftests%2fselftest.pl
=== modified file 'source/script/tests/Samba3.pm'
--- a/source/script/tests/Samba3.pm 2007-03-21 15:57:07 +0000
+++ b/source/script/tests/Samba3.pm 2007-04-04 13:22:46 +0000
@@ -121,9 +121,9 @@
return $failed;
}
-sub setup_env($$)
+sub setup_env($$$)
{
- my ($self, $name) = @_;
+ my ($self, $name, $socket_wrapper_dir) = @_;
}
1;
=== modified file 'source/script/tests/Samba4.pm'
--- a/source/script/tests/Samba4.pm 2007-03-27 04:21:16 +0000
+++ b/source/script/tests/Samba4.pm 2007-04-04 13:22:46 +0000
@@ -68,8 +68,7 @@
$self->provision_ldap();
}
- warn("Not using socket wrapper, but also not running as root. Will not be able to listen on proper ports") unless
- defined($socket_wrapper_dir) or $< == 0;
+ SocketWrapper::set_default_iface(1);
unlink($env_vars->{SMBD_TEST_FIFO});
POSIX::mkfifo($env_vars->{SMBD_TEST_FIFO}, 0700);
@@ -115,21 +114,22 @@
return $pid;
}
-sub wait_for_start($)
+sub wait_for_start($$)
{
+ my ($self, $testenv_vars) = @_;
# give time for nbt server to register its names
print "delaying for nbt name registration\n";
# This will return quickly when things are up, but be slow if we
# need to wait for (eg) SSL init
- system("bin/nmblookup $ENV{CONFIGURATION} $ENV{SERVER}");
- system("bin/nmblookup $ENV{CONFIGURATION} -U $ENV{SERVER} $ENV{SERVER}");
- system("bin/nmblookup $ENV{CONFIGURATION} $ENV{SERVER}");
- system("bin/nmblookup $ENV{CONFIGURATION} -U $ENV{SERVER} $ENV{NETBIOSNAME}");
- system("bin/nmblookup $ENV{CONFIGURATION} $ENV{NETBIOSNAME}");
- system("bin/nmblookup $ENV{CONFIGURATION} -U $ENV{SERVER} $ENV{NETBIOSNAME}");
- system("bin/nmblookup $ENV{CONFIGURATION} $ENV{NETBIOSNAME}");
- system("bin/nmblookup $ENV{CONFIGURATION} -U $ENV{SERVER} $ENV{NETBIOSNAME}");
+ system("bin/nmblookup $testenv_vars->{CONFIGURATION} $testenv_vars->{SERVER}");
+ system("bin/nmblookup $testenv_vars->{CONFIGURATION} -U $testenv_vars->{SERVER} $testenv_vars->{SERVER}");
+ system("bin/nmblookup $testenv_vars->{CONFIGURATION} $testenv_vars->{SERVER}");
+ system("bin/nmblookup $testenv_vars->{CONFIGURATION} -U $testenv_vars->{SERVER} $testenv_vars->{NETBIOSNAME}");
+ system("bin/nmblookup $testenv_vars->{CONFIGURATION} $testenv_vars->{NETBIOSNAME}");
+ system("bin/nmblookup $testenv_vars->{CONFIGURATION} -U $testenv_vars->{SERVER} $testenv_vars->{NETBIOSNAME}");
+ system("bin/nmblookup $testenv_vars->{CONFIGURATION} $testenv_vars->{NETBIOSNAME}");
+ system("bin/nmblookup $testenv_vars->{CONFIGURATION} -U $testenv_vars->{SERVER} $testenv_vars->{NETBIOSNAME}");
}
sub provision($$$)
@@ -177,9 +177,18 @@
return $failed;
}
-sub setup_env($$)
+sub setup_env($$$)
{
- my ($self, $name) = @_;
+ my ($self, $name, $path, $socket_wrapper_dir) = @_;
+
+ my $env = $self->provision($name, $path);
+
+ $self->check_or_start($env, $socket_wrapper_dir,
+ ($ENV{SMBD_MAX_TIME} or 5400));
+
+ $self->wait_for_start($env);
+
+ return $env;
}
1;
=== modified file 'source/script/tests/selftest.pl'
--- a/source/script/tests/selftest.pl 2007-03-21 16:26:25 +0000
+++ b/source/script/tests/selftest.pl 2007-04-04 13:22:46 +0000
@@ -369,8 +369,6 @@
$ENV{SRCDIR} = $srcdir;
-my $testsdir = "$srcdir/script/tests";
-
my $tls_enabled = not $opt_quick;
my $from_build_farm = (defined($ENV{RUN_FROM_BUILD_FARM}) and
($ENV{RUN_FROM_BUILD_FARM} eq "yes"));
@@ -399,6 +397,8 @@
{
$socket_wrapper_dir = SocketWrapper::setup_dir("$prefix/w");
print "SOCKET_WRAPPER_DIR=$socket_wrapper_dir\n";
+} else {
+ warn("Not using socket wrapper, but also not running as root. Will not be able to listen on proper ports") unless $< == 0;
}
my $target;
@@ -431,15 +431,10 @@
close(SKIP);
}
-my $testenv_vars;
-$testenv_vars = $target->provision("dc", "$prefix/dc");
+my $testenv_vars = $target->setup_env("dc", "$prefix/dc", $socket_wrapper_dir);
foreach (keys %$testenv_vars) { $ENV{$_} = $testenv_vars->{$_}; }
-SocketWrapper::set_default_iface(1);
-$target->check_or_start($testenv_vars, $socket_wrapper_dir,
- ($ENV{SMBD_MAX_TIME} or 5400));
-
SocketWrapper::set_default_iface(6);
my $interfaces = join(',', ("127.0.0.6/8",
@@ -463,6 +458,8 @@
my @todo = ();
+my $testsdir = "$srcdir/script/tests";
+
if ($opt_quick) {
open(IN, "$testsdir/tests_quick.sh|");
} else {
@@ -484,11 +481,6 @@
}
close(IN) or die("Error creating recipe");
-$target->wait_for_start();
-
-# start off with 0 failures
-$ENV{failed} = 0;
-
my $suitestotal = $#todo + 1;
my $i = 0;
$| = 1;
@@ -522,7 +514,7 @@
next;
}
- $target->setup_env($envname);
+ # $target->setup_env($envname);
if ($from_build_farm) {
run_test_buildfarm($name, $cmd, $i, $suitestotal);
@@ -558,13 +550,6 @@
}
print "FAILED ($statistics->{TESTS_UNEXPECTED_FAIL} failures and $statistics->{TESTS_ERROR} errors in $statistics->{SUITES_FAIL} testsuites)\n";
- } else {
- print <<EOF
-************************
-*** TESTSUITE FAILED ***
-************************
-EOF
-;
}
}
print "DURATION: $duration seconds\n";
More information about the samba-cvs
mailing list