svn commit: samba r22043 - in branches: SAMBA_3_0/source/smbd SAMBA_3_0_25/source/smbd

vlendec at samba.org vlendec at samba.org
Mon Apr 2 19:46:27 GMT 2007


Author: vlendec
Date: 2007-04-02 19:46:27 +0000 (Mon, 02 Apr 2007)
New Revision: 22043

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22043

Log:
Comparing lanman.c with -r22013 is now MUCH easier, thanks! This looks much
easier to review! Damn close to what I had in my tree, just the fn names were
slightly different.

This removes one unnecessary dupe.

Next thing is to get rid of the parameter "n" of skip_string, there is only
one (!) caller that does not pass in 1....

Volker
Modified:
   branches/SAMBA_3_0/source/smbd/lanman.c
   branches/SAMBA_3_0_25/source/smbd/lanman.c


Changeset:
Modified: branches/SAMBA_3_0/source/smbd/lanman.c
===================================================================
--- branches/SAMBA_3_0/source/smbd/lanman.c	2007-04-02 19:04:57 UTC (rev 22042)
+++ branches/SAMBA_3_0/source/smbd/lanman.c	2007-04-02 19:46:27 UTC (rev 22043)
@@ -921,9 +921,6 @@
 		return False;
 	}
 
-	uLevel = SVAL(p,0);
-	output_format2 = p + 4;
-
 	memset((char *)&desc,'\0',sizeof(desc));
 
 	DEBUG(3,("DosPrintQEnum uLevel=%d\n",uLevel));

Modified: branches/SAMBA_3_0_25/source/smbd/lanman.c
===================================================================
--- branches/SAMBA_3_0_25/source/smbd/lanman.c	2007-04-02 19:04:57 UTC (rev 22042)
+++ branches/SAMBA_3_0_25/source/smbd/lanman.c	2007-04-02 19:46:27 UTC (rev 22043)
@@ -921,9 +921,6 @@
 		return False;
 	}
 
-	uLevel = SVAL(p,0);
-	output_format2 = p + 4;
-
 	memset((char *)&desc,'\0',sizeof(desc));
 
 	DEBUG(3,("DosPrintQEnum uLevel=%d\n",uLevel));



More information about the samba-cvs mailing list