svn commit: samba r18840 - in branches/SAMBA_4_0/source/lib/ldb/tools: .

[tridge at samba.org]

Author: tridge
Date: 2006-09-23 04:36:30 +0000 (Sat, 23 Sep 2006)
New Revision: 18840

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=18840

Log:

make these compatible with g++ warnings

Modified:
   branches/SAMBA_4_0/source/lib/ldb/tools/cmdline.c
   branches/SAMBA_4_0/source/lib/ldb/tools/ldbedit.c


Changeset:
Modified: branches/SAMBA_4_0/source/lib/ldb/tools/cmdline.c
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/tools/cmdline.c	2006-09-23 02:45:06 UTC (rev 18839)
+++ branches/SAMBA_4_0/source/lib/ldb/tools/cmdline.c	2006-09-23 04:36:30 UTC (rev 18840)
@@ -26,7 +26,7 @@
 #include "ldb/include/includes.h"
 #include "ldb/tools/cmdline.h"
 
-#ifdef _SAMBA_BUILD_
+#if (_SAMBA_BUILD_ >= 4)
 #include "lib/cmdline/popt_common.h"
 #include "lib/ldb/samba/ldif_handlers.h"
 #include "auth/auth.h"
@@ -44,7 +44,7 @@
 	static struct ldb_cmdline options; /* needs to be static for older compilers */
 	struct ldb_cmdline *ret=NULL;
 	poptContext pc;
-#ifdef _SAMBA_BUILD_
+#if (_SAMBA_BUILD_ >= 4)
 	int r;
 #endif
 	int num_options = 0;
@@ -70,7 +70,7 @@
 		{ "output", 'O', POPT_ARG_STRING, &options.output, 0, "Output File", "Output" },
 		{ NULL,    'o', POPT_ARG_STRING, NULL, 'o', "ldb_connect option", "OPTION" },
 		{ "controls", 0, POPT_ARG_STRING, NULL, 'c', "controls", NULL },
-#ifdef _SAMBA_BUILD_
+#if (_SAMBA_BUILD_ >= 4)
 		POPT_COMMON_SAMBA
 		POPT_COMMON_CREDENTIALS
 		POPT_COMMON_VERSION
@@ -80,7 +80,7 @@
 
 	ldb_global_init();
 
-#ifdef _SAMBA_BUILD_
+#if (_SAMBA_BUILD_ >= 4)
 	r = ldb_register_samba_handlers(ldb);
 	if (r != 0) {
 		goto failed;
@@ -206,7 +206,7 @@
 		flags |= LDB_FLG_NOSYNC;
 	}
 
-#ifdef _SAMBA_BUILD_
+#if (_SAMBA_BUILD_ >= 4)
 	/* Must be after we have processed command line options */
 	gensec_init(); 
 	

Modified: branches/SAMBA_4_0/source/lib/ldb/tools/ldbedit.c
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/tools/ldbedit.c	2006-09-23 02:45:06 UTC (rev 18839)
+++ branches/SAMBA_4_0/source/lib/ldb/tools/ldbedit.c	2006-09-23 04:36:30 UTC (rev 18840)
@@ -189,7 +189,7 @@
 {
 	int fd, ret;
 	FILE *f;
-	char template[] = "/tmp/ldbedit.XXXXXX";
+	char file_template[] = "/tmp/ldbedit.XXXXXX";
 	char *cmd;
 	struct ldb_ldif *ldif;
 	struct ldb_message **msgs2 = NULL;
@@ -197,10 +197,10 @@
 
 	/* write out the original set of messages to a temporary
 	   file */
-	fd = mkstemp(template);
+	fd = mkstemp(file_template);
 
 	if (fd == -1) {
-		perror(template);
+		perror(file_template);
 		return -1;
 	}
 
@@ -209,7 +209,7 @@
 	if (!f) {
 		perror("fopen");
 		close(fd);
-		unlink(template);
+		unlink(file_template);
 		return -1;
 	}
 
@@ -219,10 +219,10 @@
 
 	fclose(f);
 
-	cmd = talloc_asprintf(ldb, "%s %s", editor, template);
+	cmd = talloc_asprintf(ldb, "%s %s", editor, file_template);
 
 	if (!cmd) {
-		unlink(template);
+		unlink(file_template);
 		fprintf(stderr, "out of memory\n");
 		return -1;
 	}
@@ -232,15 +232,15 @@
 	talloc_free(cmd);
 
 	if (ret != 0) {
-		unlink(template);
+		unlink(file_template);
 		fprintf(stderr, "edit with %s failed\n", editor);
 		return -1;
 	}
 
 	/* read the resulting ldif into msgs2 */
-	f = fopen(template, "r");
+	f = fopen(file_template, "r");
 	if (!f) {
-		perror(template);
+		perror(file_template);
 		return -1;
 	}
 
@@ -254,7 +254,7 @@
 	}
 
 	fclose(f);
-	unlink(template);
+	unlink(file_template);
 
 	return merge_edits(ldb, msgs1, count1, msgs2, count2);
 }