svn commit: samba r18587 - in branches/SAMBA_4_0/source/libnet: .

Rafal Szczesniak mimir at samba.org
Sat Sep 16 20:07:27 GMT 2006


Tridge,

On Sat, Sep 16, 2006 at 05:59:34PM +0000, tridge at samba.org wrote:
> Author: tridge
> Date: 2006-09-16 17:59:33 +0000 (Sat, 16 Sep 2006)
> New Revision: 18587
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=18587
> 
> Log:
> 
> fixed a potential memory leak in libnet

How did that introduce a memory leak ? Should libnet ctx as a parent not
depend on any other ?

> Changeset:
> Modified: branches/SAMBA_4_0/source/libnet/libnet.c
> ===================================================================
> --- branches/SAMBA_4_0/source/libnet/libnet.c	2006-09-16 17:57:50 UTC (rev 18586)
> +++ branches/SAMBA_4_0/source/libnet/libnet.c	2006-09-16 17:59:33 UTC (rev 18587)
> @@ -27,7 +27,7 @@
>  	struct libnet_context *ctx;
>  
>  	/* create brand new libnet context */ 
> -	ctx = talloc(NULL, struct libnet_context);
> +	ctx = talloc(ev, struct libnet_context);
>  	if (!ctx) {
>  		return NULL;
>  	}

cheers,
-- 
Rafal Szczesniak
Samba Team member  http://www.samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/samba-cvs/attachments/20060916/03d47905/attachment.bin


More information about the samba-cvs mailing list