svn commit: samba r18410 - in branches/SAMBA_4_0/source/lib/ldb/ldb_ildap: .

abartlet at samba.org abartlet at samba.org
Tue Sep 12 00:41:49 GMT 2006


Author: abartlet
Date: 2006-09-12 00:41:49 +0000 (Tue, 12 Sep 2006)
New Revision: 18410

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=18410

Log:
Reduce noise in the ldb_ildap backend.  We regularly search for things
that don't exist, and this is not a cause for panic.

Andrew Bartlett

Modified:
   branches/SAMBA_4_0/source/lib/ldb/ldb_ildap/ldb_ildap.c


Changeset:
Modified: branches/SAMBA_4_0/source/lib/ldb/ldb_ildap/ldb_ildap.c
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/ldb_ildap/ldb_ildap.c	2006-09-12 00:41:12 UTC (rev 18409)
+++ branches/SAMBA_4_0/source/lib/ldb/ldb_ildap/ldb_ildap.c	2006-09-12 00:41:49 UTC (rev 18410)
@@ -124,8 +124,7 @@
 	if (NT_STATUS_IS_OK(status)) {
 		return LDB_SUCCESS;
 	}
-	talloc_free(ildb->ldb->err_string);
-	ildb->ldb->err_string = talloc_strdup(ildb, ldap_errstr(ildb->ldap, status));
+	ldb_set_errstring(ildb->ldb, ldap_errstr(ildb->ldap, status));
 	if (NT_STATUS_IS_LDAP(status)) {
 		return NT_STATUS_LDAP_CODE(status);
 	}
@@ -246,7 +245,6 @@
 
 				status = ldap_check_response(req->conn, &msg->r.GeneralResult);
 				if (!NT_STATUS_IS_OK(status)) {
-					ldb_debug(ac->module->ldb, LDB_DEBUG_ERROR, "Error: %s\n" ,ldap_errstr(req->conn, status));
 					handle->status = ildb_map_error(ildb, status);
 					return;
 				}



More information about the samba-cvs mailing list