svn commit: samba r18356 - in branches/SAMBA_4_0/source/torture/rpc: .

tridge at samba.org tridge at samba.org
Mon Sep 11 02:58:45 GMT 2006


Author: tridge
Date: 2006-09-11 02:58:45 +0000 (Mon, 11 Sep 2006)
New Revision: 18356

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=18356

Log:

doing 1000 of these requests can take over an hour under
valgrind. Reduce to 50, which is plenty for testing the code

Modified:
   branches/SAMBA_4_0/source/torture/rpc/lsa.c


Changeset:
Modified: branches/SAMBA_4_0/source/torture/rpc/lsa.c
===================================================================
--- branches/SAMBA_4_0/source/torture/rpc/lsa.c	2006-09-11 02:09:03 UTC (rev 18355)
+++ branches/SAMBA_4_0/source/torture/rpc/lsa.c	2006-09-11 02:58:45 UTC (rev 18356)
@@ -514,8 +514,6 @@
 	return True;
 }
 
-#define NUM_ASYNC_REQUESTS 1000
-
 static void lookupsids_cb(struct rpc_request *req)
 {
 	int *replies = (int *)req->async.private;
@@ -536,26 +534,29 @@
 {
 	struct lsa_SidArray sids;
 	struct lsa_SidPtr sidptr;
-
-	uint32_t count[NUM_ASYNC_REQUESTS];
-	struct lsa_TransNameArray names[NUM_ASYNC_REQUESTS];
-	struct lsa_LookupSids r[NUM_ASYNC_REQUESTS];
+	uint32_t *count;
+	struct lsa_TransNameArray *names;
+	struct lsa_LookupSids *r;
 	struct rpc_request **req;
-
 	int i, replies;
 	BOOL ret = True;
+	const int num_async_requests = 50;
 
-	printf("\nTesting %d async lookupsids request\n", 100);
+	count = talloc_array(mem_ctx, uint32_t, num_async_requests);
+	names = talloc_array(mem_ctx, struct lsa_TransNameArray, num_async_requests);
+	r = talloc_array(mem_ctx, struct lsa_LookupSids, num_async_requests);
 
-	req = talloc_array(mem_ctx, struct rpc_request *, NUM_ASYNC_REQUESTS);
+	printf("\nTesting %d async lookupsids request\n", num_async_requests);
 
+	req = talloc_array(mem_ctx, struct rpc_request *, num_async_requests);
+
 	sids.num_sids = 1;
 	sids.sids = &sidptr;
 	sidptr.sid = dom_sid_parse_talloc(mem_ctx, "S-1-5-32-545");
 
 	replies = 0;
 
-	for (i=0; i<NUM_ASYNC_REQUESTS; i++) {
+	for (i=0; i<num_async_requests; i++) {
 		count[i] = 0;
 		names[i].count = 0;
 		names[i].names = NULL;
@@ -578,7 +579,7 @@
 		req[i]->async.private = &replies;
 	}
 
-	while (replies < NUM_ASYNC_REQUESTS) {
+	while (replies < num_async_requests) {
 		event_loop_once(p->conn->event_ctx);
 		if (replies < 0) {
 			ret = False;



More information about the samba-cvs mailing list