svn commit: samba r18011 - in branches/SAMBA_3_0: examples/libsmbclient source/libsmb

derrell at samba.org derrell at samba.org
Sun Sep 3 02:24:15 GMT 2006


Jeremy Allison <jra at samba.org> writes:

> On Sun, Sep 03, 2006 at 12:50:36AM +0000, derrell at samba.org wrote:
>> 
>> Please confirm this smb_rw_error change will have no other adverse effects
>> that you can see.
>
> The change shouldn't have any adverse effects, but what I'm
> curious about is why 'smb_read_error' was zero at that point ?
>
> All paths through that code should end up setting 'smb_read_error'
> nonzero on error or timeout.

I may, have inferred a non-truth.  I'll set that back to smb_read_error and
have Henrik test it with the other, clearly-required fixes in this patch and
see what happens.  He has an environment set up that seems to easily reproduce
the problem, so we'll know quickly.

Thanks!

Derrell


More information about the samba-cvs mailing list