svn commit: samba r17985 - in branches/SAMBA_3_0_23/source/libsmb: .

jra at samba.org jra at samba.org
Fri Sep 1 06:01:16 GMT 2006


Author: jra
Date: 2006-09-01 06:01:16 +0000 (Fri, 01 Sep 2006)
New Revision: 17985

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17985

Log:
Ensure the production branch gets Vl's fix.

------------------------------------------------
To be honest, I have NO idea whatsoever what this does, but it fixes what I
have been able to reproduce with smbtorture4 for bug number 4059. It's too
late here now to check with W2k native, I'll do that tomorrow or over the
weekend. I'll then also check in a samba4 torture test to walk this from now
on.

Volker
------------------------------------------------

Modified:
   branches/SAMBA_3_0_23/source/libsmb/ntlmssp.c


Changeset:
Modified: branches/SAMBA_3_0_23/source/libsmb/ntlmssp.c
===================================================================
--- branches/SAMBA_3_0_23/source/libsmb/ntlmssp.c	2006-09-01 04:41:03 UTC (rev 17984)
+++ branches/SAMBA_3_0_23/source/libsmb/ntlmssp.c	2006-09-01 06:01:16 UTC (rev 17985)
@@ -749,13 +749,14 @@
 				SMBsesskeygen_lm_sess_key(lm_session_key.data, ntlmssp_state->lm_resp.data, 
 							  session_key.data);
 				DEBUG(10,("ntlmssp_server_auth: Created NTLM session key.\n"));
-				dump_data_pw("LM session key:\n", session_key.data, session_key.length);
 			} else {
-				/* use the key unmodified - it's
-				 * probably a NULL key from the guest
-				 * login */
-				session_key = lm_session_key;
+				static const uint8 zeros[24] = { 0, };
+				SMBsesskeygen_lm_sess_key(
+					lm_session_key.data, zeros,
+					session_key.data);
 			}
+			dump_data_pw("LM session key:\n", session_key.data,
+				     session_key.length);
 		} else {
 			DEBUG(10,("ntlmssp_server_auth: Failed to create NTLM session key.\n"));
 			session_key = data_blob(NULL, 0);



More information about the samba-cvs mailing list