svn commit: samba r19332 - in branches/SAMBA_4_0/source: dsdb/samdb/ldb_modules lib/ldb/modules lib/ldb/tools

idra at samba.org idra at samba.org
Mon Oct 16 12:03:56 GMT 2006


Author: idra
Date: 2006-10-16 12:03:55 +0000 (Mon, 16 Oct 2006)
New Revision: 19332

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=19332

Log:

ldb_parse_tree leaks


Modified:
   branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/local_password.c
   branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/password_hash.c
   branches/SAMBA_4_0/source/lib/ldb/modules/objectclass.c
   branches/SAMBA_4_0/source/lib/ldb/tools/ldbsearch.c


Changeset:
Modified: branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/local_password.c
===================================================================
--- branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/local_password.c	2006-10-16 11:58:19 UTC (rev 19331)
+++ branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/local_password.c	2006-10-16 12:03:55 UTC (rev 19332)
@@ -402,7 +402,7 @@
 	ac->search_req->operation = LDB_SEARCH;
 	ac->search_req->op.search.base = ac->orig_req->op.mod.message->dn;
 	ac->search_req->op.search.scope = LDB_SCOPE_BASE;
-	ac->search_req->op.search.tree = ldb_parse_tree(ac->module->ldb, NULL);
+	ac->search_req->op.search.tree = ldb_parse_tree(ac->orig_req, NULL);
 	if (ac->search_req->op.search.tree == NULL) {
 		ldb_set_errstring(ac->module->ldb, "Invalid search filter");
 		return LDB_ERR_OPERATIONS_ERROR;
@@ -601,7 +601,7 @@
 		}
 		req->operation = LDB_SEARCH;
 		req->op.search.scope = LDB_SCOPE_BASE;
-		req->op.search.tree = ldb_parse_tree(ac->module->ldb, NULL);
+		req->op.search.tree = ldb_parse_tree(req, NULL);
 		if (req->op.search.tree == NULL) {
 			ldb_set_errstring(ac->module->ldb, "Out of Memory");
 			return LDB_ERR_OPERATIONS_ERROR;

Modified: branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/password_hash.c
===================================================================
--- branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/password_hash.c	2006-10-16 11:58:19 UTC (rev 19331)
+++ branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/password_hash.c	2006-10-16 12:03:55 UTC (rev 19332)
@@ -924,7 +924,7 @@
 	ac->search_req->operation = LDB_SEARCH;
 	ac->search_req->op.search.base = ac->orig_req->op.mod.message->dn;
 	ac->search_req->op.search.scope = LDB_SCOPE_BASE;
-	ac->search_req->op.search.tree = ldb_parse_tree(ac->module->ldb, NULL);
+	ac->search_req->op.search.tree = ldb_parse_tree(ac->search_req, NULL);
 	if (ac->search_req->op.search.tree == NULL) {
 		ldb_set_errstring(ac->module->ldb, "Invalid search filter");
 		return LDB_ERR_OPERATIONS_ERROR;

Modified: branches/SAMBA_4_0/source/lib/ldb/modules/objectclass.c
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/modules/objectclass.c	2006-10-16 11:58:19 UTC (rev 19331)
+++ branches/SAMBA_4_0/source/lib/ldb/modules/objectclass.c	2006-10-16 12:03:55 UTC (rev 19332)
@@ -464,7 +464,7 @@
 	ac->search_req->operation = LDB_SEARCH;
 	ac->search_req->op.search.base = ac->orig_req->op.mod.message->dn;
 	ac->search_req->op.search.scope = LDB_SCOPE_BASE;
-	ac->search_req->op.search.tree = ldb_parse_tree(ac->module->ldb, NULL);
+	ac->search_req->op.search.tree = ldb_parse_tree(ac->search_req, NULL);
 	if (ac->search_req->op.search.tree == NULL) {
 		ldb_set_errstring(ac->module->ldb, "objectclass: Internal error producing null search");
 		return LDB_ERR_OPERATIONS_ERROR;

Modified: branches/SAMBA_4_0/source/lib/ldb/tools/ldbsearch.c
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/tools/ldbsearch.c	2006-10-16 11:58:19 UTC (rev 19331)
+++ branches/SAMBA_4_0/source/lib/ldb/tools/ldbsearch.c	2006-10-16 12:03:55 UTC (rev 19332)
@@ -215,7 +215,7 @@
 	req->operation = LDB_SEARCH;
 	req->op.search.base = basedn;
 	req->op.search.scope = options->scope;
-	req->op.search.tree = ldb_parse_tree(ldb, expression);
+	req->op.search.tree = ldb_parse_tree(req, expression);
 	if (req->op.search.tree == NULL) return -1;
 	req->op.search.attrs = attrs;
 	req->controls = sctx->req_ctrls;



More information about the samba-cvs mailing list