svn commit: samba r19312 - in branches/SAMBA_4_0/source/lib/ldb/modules: .

[idra at samba.org]

Author: idra
Date: 2006-10-16 02:45:18 +0000 (Mon, 16 Oct 2006)
New Revision: 19312

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=19312

Log:

This should fix a nasty bug with values and names being freed before the results where used.
Seem that el is hanging out of a request, and the target is put on the final results.

Still one to catch and fix, but this seem to cure most of them


Modified:
   branches/SAMBA_4_0/source/lib/ldb/modules/ldb_map_outbound.c


Changeset:
Modified: branches/SAMBA_4_0/source/lib/ldb/modules/ldb_map_outbound.c
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/modules/ldb_map_outbound.c	2006-10-16 01:38:00 UTC (rev 19311)
+++ branches/SAMBA_4_0/source/lib/ldb/modules/ldb_map_outbound.c	2006-10-16 02:45:18 UTC (rev 19312)
@@ -202,7 +202,11 @@
 		}
 	}
 
-	*old = *el;			/* copy new element */
+	/* copy new element */
+	*old = *el;
+	/* and make sure we reference the contents */
+	talloc_reference(msg->elements, el->name);
+	talloc_reference(msg->elements, el->values);
 
 	return 0;
 }