svn commit: samba r19190 - in branches/SAMBA_3_0/source/lib/ldb/common: .

metze at samba.org metze at samba.org
Mon Oct 9 08:23:00 GMT 2006


Author: metze
Date: 2006-10-09 08:22:59 +0000 (Mon, 09 Oct 2006)
New Revision: 19190

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=19190

Log:
merge from samba4:

remove wrong check and statement.
to manipulate rootDSE we use ldb_dn_new() as base and that has 0 elements.

metze
Modified:
   branches/SAMBA_3_0/source/lib/ldb/common/ldb_msg.c


Changeset:
Modified: branches/SAMBA_3_0/source/lib/ldb/common/ldb_msg.c
===================================================================
--- branches/SAMBA_3_0/source/lib/ldb/common/ldb_msg.c	2006-10-09 08:11:35 UTC (rev 19189)
+++ branches/SAMBA_3_0/source/lib/ldb/common/ldb_msg.c	2006-10-09 08:22:59 UTC (rev 19190)
@@ -229,7 +229,7 @@
 
 	if (val.length == 0) {
 		/* allow empty strings as non-existant attributes */
-		return 0;
+		return LDB_SUCCESS;
 	}
 
 	return ldb_msg_add_value(msg, attr_name, &val);
@@ -596,11 +596,6 @@
 		ldb_set_errstring(ldb, "ldb message lacks a DN!");
 		return LDB_ERR_INVALID_DN_SYNTAX;
 	}
-	if (msg->dn->comp_num == 0) {
-		/* root dse has empty dn */
-		ldb_set_errstring(ldb, "DN on new ldb message is '' (not permitted)!");
-		return LDB_ERR_ENTRY_ALREADY_EXISTS;
-	}
 
 	/* basic syntax checks */
 	for (i = 0; i < msg->num_elements; i++) {



More information about the samba-cvs mailing list