svn commit: samba r19132 - in branches/SAMBA_3_0/source/lib/ldb/common: .

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> Fix some C++ warnings. Is there interest to have them in Samba4 as well?
> 
> I have some problems resolving the last 3 ones in attrib_handlers.c. In line
> 251 the function ldb_dn_explode_casefold is called with mem_ctx as the first
> argument. Looking at ldb_dn_explode_casefold I see that the first argument it
> expects is a struct ldb_context. I could certainly add a cast to (struct
> ldb_context *) to that call, but I would assume that this is the wrong fix. Is
> it possible that attrib_handlers.c:251 and :254 should have ldb and not
> mem_ctx as the first argument?
> 
> Can anybody from Samba4 clarify this for me and apply the correct fix?

Hi Volker,

I'll have a look...

>  	/* spaces not admitted */
> -	modstr = talloc_strdup_no_spaces(mem_ctx, string);
> +	modstr = talloc_strdup_no_spaces((struct ldb_context *)mem_ctx,
> +					 string);

is this that same thing?

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFFJm7Ym70gjA5TCD8RAtphAKCwHLLPDl8GtSXy0mZdu8/YcpzXbACffeMc
RUnnmxOc7EgJNMgRm7x4fRk=
=TeCH
-----END PGP SIGNATURE-----