svn commit: samba r19113 - in branches/SAMBA_4_0/source/lib/ldb/common: .

[simo]

On Fri, 2006-10-06 at 06:42 +0000, tridge at samba.org wrote:
> Author: tridge
> Date: 2006-10-06 06:42:05 +0000 (Fri, 06 Oct 2006)
> New Revision: 19113
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=19113
> 
> Log:
> 
> fixed another checker warning.
> 
> Modified:
>    branches/SAMBA_4_0/source/lib/ldb/common/ldb_dn.c
> 
> 
> Changeset:
> Modified: branches/SAMBA_4_0/source/lib/ldb/common/ldb_dn.c
> ===================================================================
> --- branches/SAMBA_4_0/source/lib/ldb/common/ldb_dn.c	2006-10-06 06:38:26 UTC (rev 19112)
> +++ branches/SAMBA_4_0/source/lib/ldb/common/ldb_dn.c	2006-10-06 06:42:05 UTC (rev 19113)
> @@ -597,6 +597,7 @@
>  		struct ldb_dn_component dc;
>  		const struct ldb_attrib_handler *h;
>  
> +		memset(&dc, 0, sizeof(dc));
>  		dc.name = ldb_attr_casefold(cedn, edn->components[i].name);
>  		if (!dc.name) {
>  			talloc_free(cedn);

Tridge,
isn't there another way to fix the warning?
It is just a waste of time imo to memset memory the will be assigned and
copied out immediately after.

Simo.


-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org