svn commit: samba r19809 - in branches/SAMBA_3_0/source: nsswitch param

[jerry at samba.org]

Author: jerry
Date: 2006-11-21 00:00:43 +0000 (Tue, 21 Nov 2006)
New Revision: 19809

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=19809

Log:
remove winbind blacklist parameter


Modified:
   branches/SAMBA_3_0/source/nsswitch/winbindd_group.c
   branches/SAMBA_3_0/source/param/loadparm.c


Changeset:
Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_group.c
===================================================================
--- branches/SAMBA_3_0/source/nsswitch/winbindd_group.c	2006-11-21 00:00:18 UTC (rev 19808)
+++ branches/SAMBA_3_0/source/nsswitch/winbindd_group.c	2006-11-21 00:00:43 UTC (rev 19809)
@@ -1130,30 +1130,6 @@
 	DEBUG(3, ("[%5lu]: getgroups %s\n", (unsigned long)state->pid,
 		  state->request.data.username));
 
-	/* when using "winbind use default domain" we need to avoid that
-	 * initgroups() requests from NSS hit our DC too badly for accounts
-	 * that will never be on the remote DC */
-
-	if (lp_winbind_use_default_domain()) {
-		
-		const char **list = lp_winbind_initgroups_blacklist();
-		int i;
-
-		if (!list || !list[0]) {
-			goto parse;
-		}
-
-		for (i=0; list[i] != NULL; i++) {
-	
-			if (strequal(state->request.data.username, list[i])) {
-				DEBUG(3,("ignoring blacklisted user [%s] for getgroups\n", 
-					state->request.data.username));
-				request_ok(state);
-				return;
-			}
-		}
-	}
- parse:
 	/* Parse domain and username */
 
 	s = TALLOC_P(state->mem_ctx, struct getgroups_state);

Modified: branches/SAMBA_3_0/source/param/loadparm.c
===================================================================
--- branches/SAMBA_3_0/source/param/loadparm.c	2006-11-21 00:00:18 UTC (rev 19808)
+++ branches/SAMBA_3_0/source/param/loadparm.c	2006-11-21 00:00:43 UTC (rev 19809)
@@ -181,7 +181,6 @@
 	BOOL bWinbindRefreshTickets;
 	BOOL bWinbindOfflineLogon;
 	char **szIdmapBackend;
-	char **szWinbindInitgroupsBlacklist;
 	char *szAddShareCommand;
 	char *szChangeShareCommand;
 	char *szDeleteShareCommand;
@@ -1279,7 +1278,6 @@
 	{"winbind nss info", P_LIST, P_GLOBAL, &Globals.szWinbindNssInfo, NULL, NULL, FLAG_ADVANCED}, 
 	{"winbind refresh tickets", P_BOOL, P_GLOBAL, &Globals.bWinbindRefreshTickets, NULL, NULL, FLAG_ADVANCED}, 
 	{"winbind offline logon", P_BOOL, P_GLOBAL, &Globals.bWinbindOfflineLogon, NULL, NULL, FLAG_ADVANCED},
-	{"winbind initgroups blacklist", P_LIST, P_GLOBAL, &Globals.szWinbindInitgroupsBlacklist, NULL, NULL, FLAG_ADVANCED},
 
 	{NULL,  P_BOOL,  P_NONE,  NULL,  NULL,  NULL,  0}
 };
@@ -1626,7 +1624,6 @@
 	Globals.szWinbindNssInfo = str_list_make("template", NULL);
 	Globals.bWinbindRefreshTickets = False;
 	Globals.bWinbindOfflineLogon = False;
-	Globals.szWinbindInitgroupsBlacklist = str_list_make("root nobody lp", NULL);
 
 	Globals.bPassdbExpandExplicit = False;
 
@@ -1844,7 +1841,6 @@
 FN_GLOBAL_BOOL(lp_winbind_offline_logon, &Globals.bWinbindOfflineLogon)
 
 FN_GLOBAL_LIST(lp_idmap_backend, &Globals.szIdmapBackend)
-FN_GLOBAL_LIST(lp_winbind_initgroups_blacklist, &Globals.szWinbindInitgroupsBlacklist)
 FN_GLOBAL_BOOL(lp_passdb_expand_explicit, &Globals.bPassdbExpandExplicit)
 
 FN_GLOBAL_STRING(lp_ldap_suffix, &Globals.szLdapSuffix)