svn commit: samba r19659 - in branches: SAMBA_3_0/source/libsmb SAMBA_3_0_23/source/libsmb SAMBA_3_0_24/source/libsmb

[jra at samba.org]

Author: jra
Date: 2006-11-11 00:23:44 +0000 (Sat, 11 Nov 2006)
New Revision: 19659

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=19659

Log:
Fix bug #4187. Possible crash in signing on/off code.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/libsmb/smb_signing.c
   branches/SAMBA_3_0_23/source/libsmb/smb_signing.c
   branches/SAMBA_3_0_24/source/libsmb/smb_signing.c


Changeset:
Modified: branches/SAMBA_3_0/source/libsmb/smb_signing.c
===================================================================
--- branches/SAMBA_3_0/source/libsmb/smb_signing.c	2006-11-10 23:30:07 UTC (rev 19658)
+++ branches/SAMBA_3_0/source/libsmb/smb_signing.c	2006-11-11 00:23:44 UTC (rev 19659)
@@ -616,6 +616,10 @@
 		return True;
 	}
 
+	if (!data) {
+		return False;
+	}
+
 	if (!set_sequence_can_delete_flag(&data->outstanding_packet_list, mid, False)) {
 		return False;
 	}
@@ -637,6 +641,10 @@
 		return True;
 	}
 
+	if (!data) {
+		return False;
+	}
+
 	if (!set_sequence_can_delete_flag(&data->outstanding_packet_list, mid, True)) {
 		return False;
 	}

Modified: branches/SAMBA_3_0_23/source/libsmb/smb_signing.c
===================================================================
--- branches/SAMBA_3_0_23/source/libsmb/smb_signing.c	2006-11-10 23:30:07 UTC (rev 19658)
+++ branches/SAMBA_3_0_23/source/libsmb/smb_signing.c	2006-11-11 00:23:44 UTC (rev 19659)
@@ -613,6 +613,10 @@
 		return True;
 	}
 
+	if (!data) {
+		return False;
+	}
+
 	if (!set_sequence_can_delete_flag(&data->outstanding_packet_list, mid, False)) {
 		return False;
 	}
@@ -634,6 +638,10 @@
 		return True;
 	}
 
+	if (!data) {
+		return False;
+	}
+
 	if (!set_sequence_can_delete_flag(&data->outstanding_packet_list, mid, True)) {
 		return False;
 	}

Modified: branches/SAMBA_3_0_24/source/libsmb/smb_signing.c
===================================================================
--- branches/SAMBA_3_0_24/source/libsmb/smb_signing.c	2006-11-10 23:30:07 UTC (rev 19658)
+++ branches/SAMBA_3_0_24/source/libsmb/smb_signing.c	2006-11-11 00:23:44 UTC (rev 19659)
@@ -613,6 +613,10 @@
 		return True;
 	}
 
+	if (!data) {
+		return False;
+	}
+
 	if (!set_sequence_can_delete_flag(&data->outstanding_packet_list, mid, False)) {
 		return False;
 	}
@@ -634,6 +638,10 @@
 		return True;
 	}
 
+	if (!data) {
+		return False;
+	}
+
 	if (!set_sequence_can_delete_flag(&data->outstanding_packet_list, mid, True)) {
 		return False;
 	}