svn commit: samba r19527 - in branches: SAMBA_3_0/source/utils SAMBA_3_0_23/source/utils SAMBA_3_0_24/source/utils

[gd at samba.org]

Author: gd
Date: 2006-11-01 11:08:05 +0000 (Wed, 01 Nov 2006)
New Revision: 19527

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=19527

Log:
Fix double free in "net ads group add".

Guenther

Modified:
   branches/SAMBA_3_0/source/utils/net_ads.c
   branches/SAMBA_3_0_23/source/utils/net_ads.c
   branches/SAMBA_3_0_24/source/utils/net_ads.c


Changeset:
Modified: branches/SAMBA_3_0/source/utils/net_ads.c
===================================================================
--- branches/SAMBA_3_0/source/utils/net_ads.c	2006-11-01 11:04:28 UTC (rev 19526)
+++ branches/SAMBA_3_0/source/utils/net_ads.c	2006-11-01 11:08:05 UTC (rev 19527)
@@ -672,7 +672,6 @@
 	
 	if (ads_count_replies(ads, res)) {
 		d_fprintf(stderr, "ads_group_add: Group %s already exists\n", argv[0]);
-		ads_msgfree(ads, res);
 		goto done;
 	}
 

Modified: branches/SAMBA_3_0_23/source/utils/net_ads.c
===================================================================
--- branches/SAMBA_3_0_23/source/utils/net_ads.c	2006-11-01 11:04:28 UTC (rev 19526)
+++ branches/SAMBA_3_0_23/source/utils/net_ads.c	2006-11-01 11:08:05 UTC (rev 19527)
@@ -635,7 +635,6 @@
 	
 	if (ads_count_replies(ads, res)) {
 		d_fprintf(stderr, "ads_group_add: Group %s already exists\n", argv[0]);
-		ads_msgfree(ads, res);
 		goto done;
 	}
 

Modified: branches/SAMBA_3_0_24/source/utils/net_ads.c
===================================================================
--- branches/SAMBA_3_0_24/source/utils/net_ads.c	2006-11-01 11:04:28 UTC (rev 19526)
+++ branches/SAMBA_3_0_24/source/utils/net_ads.c	2006-11-01 11:08:05 UTC (rev 19527)
@@ -656,7 +656,6 @@
 	
 	if (ads_count_replies(ads, res)) {
 		d_fprintf(stderr, "ads_group_add: Group %s already exists\n", argv[0]);
-		ads_msgfree(ads, res);
 		goto done;
 	}