svn commit: samba r15932 - in branches/SAMBA_4_0/source: dsdb/samdb/ldb_modules lib/ldb/common lib/ldb/include lib/ldb/modules lib/ldb/tools

idra at samba.org idra at samba.org
Mon May 29 11:57:10 GMT 2006


Author: idra
Date: 2006-05-29 11:57:09 +0000 (Mon, 29 May 2006)
New Revision: 15932

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=15932

Log:

Remove per request creds
They have never benn used and make little sense too imo


Modified:
   branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/extended_dn.c
   branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/kludge_acl.c
   branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/password_hash.c
   branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/rootdse.c
   branches/SAMBA_4_0/source/lib/ldb/common/ldb.c
   branches/SAMBA_4_0/source/lib/ldb/include/ldb.h
   branches/SAMBA_4_0/source/lib/ldb/modules/asq.c
   branches/SAMBA_4_0/source/lib/ldb/modules/operational.c
   branches/SAMBA_4_0/source/lib/ldb/modules/paged_results.c
   branches/SAMBA_4_0/source/lib/ldb/modules/sort.c
   branches/SAMBA_4_0/source/lib/ldb/tools/ldbsearch.c


Changeset:
Modified: branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/extended_dn.c
===================================================================
--- branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/extended_dn.c	2006-05-29 11:39:07 UTC (rev 15931)
+++ branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/extended_dn.c	2006-05-29 11:57:09 UTC (rev 15932)
@@ -371,8 +371,6 @@
 		return LDB_ERR_OPERATIONS_ERROR;
 	}
 
-	down_req->creds = req->creds;
-
 	down_req->async.context = ac;
 	down_req->async.callback = extended_async_callback;
 	down_req->async.timeout = req->async.timeout;

Modified: branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/kludge_acl.c
===================================================================
--- branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/kludge_acl.c	2006-05-29 11:39:07 UTC (rev 15931)
+++ branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/kludge_acl.c	2006-05-29 11:57:09 UTC (rev 15932)
@@ -209,7 +209,6 @@
 	down_req->op.search.attrs = req->op.search.attrs;
 	
 	down_req->controls = req->controls;
-	down_req->creds = req->creds;
 
 	down_req->async.context = ac;
 	down_req->async.callback = kludge_acl_async_callback;

Modified: branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/password_hash.c
===================================================================
--- branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/password_hash.c	2006-05-29 11:39:07 UTC (rev 15931)
+++ branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/password_hash.c	2006-05-29 11:57:09 UTC (rev 15932)
@@ -1175,7 +1175,6 @@
 	}
 	ac->dom_req->op.search.attrs = attrs;
 	ac->dom_req->controls = NULL;
-	ac->dom_req->creds = ac->orig_req->creds;
 	ac->dom_req->async.context = ac;
 	ac->dom_req->async.callback = get_domain_data_callback;
 	ac->dom_req->async.timeout = ac->orig_req->async.timeout;
@@ -1507,7 +1506,6 @@
 	}
 	ac->search_req->op.search.attrs = NULL;
 	ac->search_req->controls = NULL;
-	ac->search_req->creds = ac->orig_req->creds;
 	ac->search_req->async.context = ac;
 	ac->search_req->async.callback = get_self_callback;
 	ac->search_req->async.timeout = ac->orig_req->async.timeout;

Modified: branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/rootdse.c
===================================================================
--- branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/rootdse.c	2006-05-29 11:39:07 UTC (rev 15931)
+++ branches/SAMBA_4_0/source/dsdb/samdb/ldb_modules/rootdse.c	2006-05-29 11:57:09 UTC (rev 15932)
@@ -232,7 +232,6 @@
 	}
 	down_req->op.search.attrs = req->op.search.attrs;
 	down_req->controls = req->controls;
-	down_req->creds = req->creds;
 
 	down_req->async.context = ac;
 	down_req->async.callback = rootdse_async_callback;

Modified: branches/SAMBA_4_0/source/lib/ldb/common/ldb.c
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/common/ldb.c	2006-05-29 11:39:07 UTC (rev 15931)
+++ branches/SAMBA_4_0/source/lib/ldb/common/ldb.c	2006-05-29 11:57:09 UTC (rev 15932)
@@ -444,7 +444,6 @@
 
 	req->op.search.attrs = attrs;
 	req->controls = NULL;
-	req->creds = NULL;
 	req->async.context = res;
 	req->async.callback = ldb_search_callback;
 	req->async.timeout = 600; /* 10 minutes */
@@ -512,7 +511,6 @@
 	req->operation = LDB_ASYNC_ADD;
 	req->op.add.message = message;
 	req->controls = NULL;
-	req->creds = NULL;
 	req->async.context = NULL;
 	req->async.callback = NULL;
 	req->async.timeout = 600; /* 10 minutes */
@@ -545,7 +543,6 @@
 	req->operation = LDB_ASYNC_MODIFY;
 	req->op.add.message = message;
 	req->controls = NULL;
-	req->creds = NULL;
 	req->async.context = NULL;
 	req->async.callback = NULL;
 	req->async.timeout = 600; /* 10 minutes */
@@ -575,7 +572,6 @@
 	req->operation = LDB_ASYNC_DELETE;
 	req->op.del.dn = dn;
 	req->controls = NULL;
-	req->creds = NULL;
 	req->async.context = NULL;
 	req->async.callback = NULL;
 	req->async.timeout = 600; /* 10 minutes */
@@ -605,7 +601,6 @@
 	req->op.rename.olddn = olddn;
 	req->op.rename.newdn = newdn;
 	req->controls = NULL;
-	req->creds = NULL;
 	req->async.context = NULL;
 	req->async.callback = NULL;
 	req->async.timeout = 600; /* 10 minutes */

Modified: branches/SAMBA_4_0/source/lib/ldb/include/ldb.h
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/include/ldb.h	2006-05-29 11:39:07 UTC (rev 15931)
+++ branches/SAMBA_4_0/source/lib/ldb/include/ldb.h	2006-05-29 11:57:09 UTC (rev 15932)
@@ -561,8 +561,6 @@
 	void *data;
 };
 
-struct ldb_credentials;
-
 enum ldb_request_type {
 	LDB_REQ_SEARCH,
 	LDB_REQ_ADD,
@@ -659,7 +657,6 @@
 	} op;
 
 	struct ldb_control **controls;
-	struct ldb_credentials *creds;
 
 	struct {
 		void *context;

Modified: branches/SAMBA_4_0/source/lib/ldb/modules/asq.c
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/modules/asq.c	2006-05-29 11:39:07 UTC (rev 15931)
+++ branches/SAMBA_4_0/source/lib/ldb/modules/asq.c	2006-05-29 11:57:09 UTC (rev 15932)
@@ -117,7 +117,6 @@
 		return LDB_ERR_OPERATIONS_ERROR;
 	base_attrs[1] = NULL;
 	base_req->op.search.attrs = (const char * const *)base_attrs;
-	base_req->creds = req->creds;
 
 	ret = ldb_request(module->ldb, base_req);
 
@@ -154,7 +153,6 @@
 		exp_req->op.search.scope = LDB_SCOPE_BASE;
 		exp_req->op.search.tree = req->op.search.tree;
 		exp_req->op.search.attrs = req->op.search.attrs;
-		exp_req->creds = req->creds;
 
 		ret = ldb_request(module->ldb, exp_req);
 
@@ -416,7 +414,6 @@
 		return LDB_ERR_OPERATIONS_ERROR;
 	base_attrs[1] = NULL;
 	ac->base_req->op.search.attrs = (const char * const *)base_attrs;
-	ac->base_req->creds = req->creds;
 
 	ac->base_req->async.context = ac;
 	ac->base_req->async.callback = asq_base_callback;
@@ -470,7 +467,6 @@
 		ac->reqs[i]->op.search.scope = LDB_SCOPE_BASE;
 		ac->reqs[i]->op.search.tree = ac->base_req->op.search.tree;
 		ac->reqs[i]->op.search.attrs = ac->req_attrs;
-		ac->reqs[i]->creds = ac->base_req->creds;
 
 		ac->reqs[i]->async.context = ac;
 		ac->reqs[i]->async.callback = asq_reqs_callback;

Modified: branches/SAMBA_4_0/source/lib/ldb/modules/operational.c
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/modules/operational.c	2006-05-29 11:39:07 UTC (rev 15931)
+++ branches/SAMBA_4_0/source/lib/ldb/modules/operational.c	2006-05-29 11:57:09 UTC (rev 15932)
@@ -485,7 +485,6 @@
 	else down_req->op.search.attrs = req->op.search.attrs;
 	
 	down_req->controls = req->controls;
-	down_req->creds = req->creds;
 
 	down_req->async.context = ac;
 	down_req->async.callback = operational_async_callback;

Modified: branches/SAMBA_4_0/source/lib/ldb/modules/paged_results.c
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/modules/paged_results.c	2006-05-29 11:39:07 UTC (rev 15931)
+++ branches/SAMBA_4_0/source/lib/ldb/modules/paged_results.c	2006-05-29 11:57:09 UTC (rev 15932)
@@ -431,8 +431,6 @@
 			return LDB_ERR_OPERATIONS_ERROR;
 		}
 
-		ac->store->req->creds = req->creds;
-
 		ac->store->req->async.context = ac;
 		ac->store->req->async.callback = paged_search_async_callback;
 		ac->store->req->async.timeout = req->async.timeout;

Modified: branches/SAMBA_4_0/source/lib/ldb/modules/sort.c
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/modules/sort.c	2006-05-29 11:39:07 UTC (rev 15931)
+++ branches/SAMBA_4_0/source/lib/ldb/modules/sort.c	2006-05-29 11:57:09 UTC (rev 15932)
@@ -424,8 +424,6 @@
 		return LDB_ERR_OPERATIONS_ERROR;
 	}
 
-	ac->req->creds = req->creds;
-
 	ac->req->async.context = ac;
 	ac->req->async.callback = server_sort_search_async_callback;
 	ac->req->async.timeout = req->async.timeout;

Modified: branches/SAMBA_4_0/source/lib/ldb/tools/ldbsearch.c
===================================================================
--- branches/SAMBA_4_0/source/lib/ldb/tools/ldbsearch.c	2006-05-29 11:39:07 UTC (rev 15931)
+++ branches/SAMBA_4_0/source/lib/ldb/tools/ldbsearch.c	2006-05-29 11:57:09 UTC (rev 15932)
@@ -224,7 +224,6 @@
 	if (req->op.search.tree == NULL) return -1;
 	req->op.search.attrs = attrs;
 	req->controls = actx->req_ctrls;
-	req->creds = NULL;
 	req->async.context = actx;
 	req->async.callback = &search_callback;
 	req->async.timeout = 3600; /* TODO: make this settable by command line */



More information about the samba-cvs mailing list