svn commit: samba r15889 - in trunk/source/passdb: .

jra at samba.org jra at samba.org
Thu May 25 15:44:44 GMT 2006


Author: jra
Date: 2006-05-25 15:44:43 +0000 (Thu, 25 May 2006)
New Revision: 15889

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=15889

Log:
Fix bug #3804 from jason at ncac.gwu.edu
Invalid comparisons.
Jeremy.

Modified:
   trunk/source/passdb/secrets.c


Changeset:
Modified: trunk/source/passdb/secrets.c
===================================================================
--- trunk/source/passdb/secrets.c	2006-05-25 15:44:41 UTC (rev 15888)
+++ trunk/source/passdb/secrets.c	2006-05-25 15:44:43 UTC (rev 15889)
@@ -534,7 +534,7 @@
 	struct trusted_dom_pass pass;
 	ZERO_STRUCT(pass);
 
-	if (push_ucs2_allocate(&uni_dom_name, domain) < 0) {
+	if (push_ucs2_allocate(&uni_dom_name, domain) == (size_t)-1) {
 		DEBUG(0, ("Could not convert domain name %s to unicode\n",
 			  domain));
 		return False;
@@ -865,7 +865,7 @@
 		}
 
 		if (pull_ucs2_talloc(mem_ctx, &dom_info->name,
-				     pass.uni_name) < 0) {
+				     pass.uni_name) == (size_t)-1) {
 			DEBUG(2, ("pull_ucs2_talloc failed\n"));
 			tdb_search_list_free(keys);
 			return NT_STATUS_NO_MEMORY;



More information about the samba-cvs mailing list