svn commit: samba r15591 - in branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl: Samba3 Samba4

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

jelmer at samba.org schrieb:
> Author: jelmer
> Date: 2006-05-13 23:58:16 +0000 (Sat, 13 May 2006)
> New Revision: 15591
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=15591
> 
> Log:
> Generate function calls correctly as well.
> 
> Modified:
>    branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba3/ClientNDR.pm
>    branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Samba4/SWIG.pm

Hi Jelmer,

shouldn't this be 2 commits?

where's the comment to the ClientNDR.pm change?

I also noticed this in another commit...
Can you please do svn di before committing?

I try to always do a 'svn di |less' and review my patch as if I were
reviewing a patch for someone else...and I find bugs or strange thinks
this way very often:-)

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEZwJkm70gjA5TCD8RAu1JAJ9NttsyVmGy2hFAxsruDB/kvTiyAwCgj4rS
6Hd1lk2pGJs5oR4P0oFbFLg=
=J8DU
-----END PGP SIGNATURE-----