svn commit: samba r15482 - in branches/SAMBA_4_0/source/librpc/rpc: .

abartlet at samba.org abartlet at samba.org
Sun May 7 05:35:52 GMT 2006


Author: abartlet
Date: 2006-05-07 05:35:52 +0000 (Sun, 07 May 2006)
New Revision: 15482

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=15482

Log:
Don't shadow the global function pipe() with a local variable name.

Andrew Bartlett

Modified:
   branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c


Changeset:
Modified: branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c
===================================================================
--- branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c	2006-05-07 04:51:30 UTC (rev 15481)
+++ branches/SAMBA_4_0/source/librpc/rpc/dcerpc.c	2006-05-07 05:35:52 UTC (rev 15482)
@@ -585,10 +585,8 @@
 static void dcerpc_bind_recv_data(struct dcerpc_connection *conn, struct ncacn_packet *pkt)
 {
 	struct composite_context *c;
-	struct dcerpc_pipe *pipe;
 
 	c = talloc_get_type(conn->bind_private, struct composite_context);
-	pipe = talloc_get_type(c->private_data, struct dcerpc_pipe);
 
 	/* mark the connection as not waiting for a bind reply */
 	conn->bind_private = NULL;
@@ -633,10 +631,10 @@
 {
 	struct composite_context *ctx =
 		talloc_get_type(private, struct composite_context);
-	struct dcerpc_pipe *pipe = talloc_get_type(ctx->private_data, struct dcerpc_pipe);
+	struct dcerpc_pipe *timeout_pipe = talloc_get_type(ctx->private_data, struct dcerpc_pipe);
 
-	SMB_ASSERT(pipe->conn->bind_private != NULL);
-	pipe->conn->bind_private = NULL;
+	SMB_ASSERT(timeout_pipe->conn->bind_private != NULL);
+	timeout_pipe->conn->bind_private = NULL;
 	composite_error(ctx, NT_STATUS_IO_TIMEOUT);
 }
 
@@ -1522,10 +1520,10 @@
 static void dcerpc_alter_recv_data(struct dcerpc_connection *conn, struct ncacn_packet *pkt)
 {
 	struct composite_context *c;
-	struct dcerpc_pipe *pipe;
+	struct dcerpc_pipe *recv_pipe;
 
 	c = talloc_get_type(conn->alter_private, struct composite_context);
-	pipe = talloc_get_type(c->private_data, struct dcerpc_pipe);
+	recv_pipe = talloc_get_type(c->private_data, struct dcerpc_pipe);
 
 	/* mark the connection as not waiting for a alter context reply */
 	conn->alter_private = NULL;
@@ -1547,11 +1545,11 @@
 	}
 
 	/* the alter_resp might contain a reply set of credentials */
-	if (pipe->conn->security_state.auth_info &&
+	if (recv_pipe->conn->security_state.auth_info &&
 	    pkt->u.alter_resp.auth_info.length) {
 		c->status = ndr_pull_struct_blob(
-			&pkt->u.alter_resp.auth_info, pipe,
-			pipe->conn->security_state.auth_info,
+			&pkt->u.alter_resp.auth_info, recv_pipe,
+			recv_pipe->conn->security_state.auth_info,
 			(ndr_pull_flags_fn_t)ndr_pull_dcerpc_auth);
 		if (!composite_is_ok(c)) return;
 	}



More information about the samba-cvs mailing list