svn commit: samba r15459 - in branches/SAMBA_4_0/source/libnet: .

mimir at samba.org mimir at samba.org
Fri May 5 13:57:18 GMT 2006


Author: mimir
Date: 2006-05-05 13:57:17 +0000 (Fri, 05 May 2006)
New Revision: 15459

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=15459

Log:
Add forgotten guid retrieval among other data and thus prevent
from returning uninitialised structure member. Thank heavens for build
farm and valgrind :)


rafal


Modified:
   branches/SAMBA_4_0/source/libnet/libnet_rpc.c


Changeset:
Modified: branches/SAMBA_4_0/source/libnet/libnet_rpc.c
===================================================================
--- branches/SAMBA_4_0/source/libnet/libnet_rpc.c	2006-05-05 13:16:58 UTC (rev 15458)
+++ branches/SAMBA_4_0/source/libnet/libnet_rpc.c	2006-05-05 13:57:17 UTC (rev 15459)
@@ -615,9 +615,12 @@
 		s = talloc_get_type(c->private_data, struct rpc_connect_dci_state);
 
 		r->out.realm        = talloc_steal(mem_ctx, s->r.out.realm);
+		r->out.guid         = talloc_steal(mem_ctx, s->r.out.guid);
+		r->out.domain_name  = talloc_steal(mem_ctx, s->r.out.domain_name);
 		r->out.domain_sid   = talloc_steal(mem_ctx, s->r.out.domain_sid);
-		r->out.domain_name  = talloc_steal(mem_ctx, s->r.out.domain_name);
 		r->out.dcerpc_pipe  = talloc_steal(mem_ctx, s->r.out.dcerpc_pipe);
+
+		r->out.error_string = NULL;
 	}
 
 	talloc_free(c);



More information about the samba-cvs mailing list