svn commit: samba r15393 - branches/SAMBA_3_0/source/auth trunk/source/auth

jerry at samba.org jerry at samba.org
Tue May 2 12:13:23 GMT 2006


Author: jerry
Date: 2006-05-02 12:13:23 +0000 (Tue, 02 May 2006)
New Revision: 15393

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=15393

Log:
remove extra call to fallback user creation on member servers; it's handled by the smb_getpwnam() call deeper in
Modified:
   branches/SAMBA_3_0/source/auth/auth_util.c
   trunk/source/auth/auth_util.c


Changeset:
Modified: branches/SAMBA_3_0/source/auth/auth_util.c
===================================================================
--- branches/SAMBA_3_0/source/auth/auth_util.c	2006-05-02 11:54:18 UTC (rev 15392)
+++ branches/SAMBA_3_0/source/auth/auth_util.c	2006-05-02 12:13:23 UTC (rev 15393)
@@ -1563,16 +1563,11 @@
 		return NT_STATUS_NO_MEMORY;
 	}
 
+	/* this call will try to create the user if necessary */
+
 	nt_status = fill_sam_account(mem_ctx, nt_domain, sent_nt_username,
 				     &found_username, &uid, &gid, sam_account);
 
-	if (NT_STATUS_EQUAL(nt_status, NT_STATUS_NO_SUCH_USER)) {
-		DEBUG(3,("User %s does not exist, trying to add it\n",
-			 internal_username));
-		smb_create_user( nt_domain, sent_nt_username, NULL);
-		nt_status = fill_sam_account( mem_ctx, nt_domain, sent_nt_username, 
-					      &found_username, &uid, &gid, sam_account );
-	}
 	
 	/* if we still don't have a valid unix account check for 
 	  'map to guest = bad uid' */

Modified: trunk/source/auth/auth_util.c
===================================================================
--- trunk/source/auth/auth_util.c	2006-05-02 11:54:18 UTC (rev 15392)
+++ trunk/source/auth/auth_util.c	2006-05-02 12:13:23 UTC (rev 15393)
@@ -1563,16 +1563,11 @@
 		return NT_STATUS_NO_MEMORY;
 	}
 
+	/* this call will try to create the user if necessary */
+
 	nt_status = fill_sam_account(mem_ctx, nt_domain, sent_nt_username,
 				     &found_username, &uid, &gid, sam_account);
 
-	if (NT_STATUS_EQUAL(nt_status, NT_STATUS_NO_SUCH_USER)) {
-		DEBUG(3,("User %s does not exist, trying to add it\n",
-			 internal_username));
-		smb_create_user( nt_domain, sent_nt_username, NULL);
-		nt_status = fill_sam_account( mem_ctx, nt_domain, sent_nt_username, 
-					      &found_username, &uid, &gid, sam_account );
-	}
 	
 	/* if we still don't have a valid unix account check for 
 	  'map to guest = bad uid' */



More information about the samba-cvs mailing list