svn commit: samba r14833 - in branches/SAMBA_3_0/source/rpcclient: .

[jra at samba.org]

Author: jra
Date: 2006-03-31 00:50:09 +0000 (Fri, 31 Mar 2006)
New Revision: 14833

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14833

Log:
Fix resource leak on error code path. Coverity #280.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/rpcclient/cmd_spoolss.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpcclient/cmd_spoolss.c
===================================================================
--- branches/SAMBA_3_0/source/rpcclient/cmd_spoolss.c	2006-03-31 00:47:19 UTC (rev 14832)
+++ branches/SAMBA_3_0/source/rpcclient/cmd_spoolss.c	2006-03-31 00:50:09 UTC (rev 14833)
@@ -2396,9 +2396,10 @@
 		curkey += strlen(subkey) + 1;
 	}
 
-	safe_free(keylist);
+done:
 
-done:
+	SAFE_FREE(keylist);
+
 	if (got_hnd)
 		rpccli_spoolss_close_printer(cli, mem_ctx, &hnd);