svn commit: samba r14376 - in trunk/source/libmsrpc: .

[idra at samba.org]

Author: idra
Date: 2006-03-14 13:57:02 +0000 (Tue, 14 Mar 2006)
New Revision: 14376

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14376

Log:

Fix coverity #4
The result is never set to CAC_SUCCESS, so the test is meaningless.
Let's just set CAC_FAILURE instead.


Modified:
   trunk/source/libmsrpc/cac_lsarpc.c


Changeset:
Modified: trunk/source/libmsrpc/cac_lsarpc.c
===================================================================
--- trunk/source/libmsrpc/cac_lsarpc.c	2006-03-14 13:49:34 UTC (rev 14375)
+++ trunk/source/libmsrpc/cac_lsarpc.c	2006-03-14 13:57:02 UTC (rev 14376)
@@ -440,7 +440,7 @@
       hnd->status = rpccli_lsa_query_info_policy( pipe_hnd, mem_ctx, op->in.pol, CAC_DOMAIN_INFO, &dom_name, &domain_sid);
       if(!NT_STATUS_IS_OK(hnd->status)) {
          /*if we succeeded above, report partial success*/
-         result = (result == CAC_SUCCESS) ? CAC_PARTIAL_SUCCESS : CAC_FAILURE;
+         result = CAC_FAILURE;
          goto done;
       }
       else if(result == CAC_FAILURE) {