svn commit: samba r14357 - in branches/SAMBA_3_0/source/smbd: .
jra at samba.org
jra at samba.org
Mon Mar 13 23:56:03 GMT 2006
Author: jra
Date: 2006-03-13 23:56:02 +0000 (Mon, 13 Mar 2006)
New Revision: 14357
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14357
Log:
Try and fix Coverity #169 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
line, and those below, will be ignored--
M source/smbd/posix_acls.c
Modified:
branches/SAMBA_3_0/source/smbd/posix_acls.c
Changeset:
Modified: branches/SAMBA_3_0/source/smbd/posix_acls.c
===================================================================
--- branches/SAMBA_3_0/source/smbd/posix_acls.c 2006-03-13 23:48:18 UTC (rev 14356)
+++ branches/SAMBA_3_0/source/smbd/posix_acls.c 2006-03-13 23:56:02 UTC (rev 14357)
@@ -516,10 +516,12 @@
static void free_canon_ace_list( canon_ace *list_head )
{
- while (list_head) {
- canon_ace *old_head = list_head;
- DLIST_REMOVE(list_head, list_head);
- SAFE_FREE(old_head);
+ canon_ace *list, *next;
+
+ for (list = list_head; list; list = next) {
+ next = list->next;
+ DLIST_REMOVE(list_head, list);
+ SAFE_FREE(list);
}
}
More information about the samba-cvs
mailing list