svn commit: samba r14338 - in branches/SAMBA_3_0/source/rpc_server:
.
jra at samba.org
jra at samba.org
Mon Mar 13 18:59:32 GMT 2006
Author: jra
Date: 2006-03-13 18:59:31 +0000 (Mon, 13 Mar 2006)
New Revision: 14338
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14338
Log:
Fix coverity #55 by explicit cast.
Jeremy.
Modified:
branches/SAMBA_3_0/source/rpc_server/srv_svcctl_nt.c
Changeset:
Modified: branches/SAMBA_3_0/source/rpc_server/srv_svcctl_nt.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_server/srv_svcctl_nt.c 2006-03-13 18:56:33 UTC (rev 14337)
+++ branches/SAMBA_3_0/source/rpc_server/srv_svcctl_nt.c 2006-03-13 18:59:31 UTC (rev 14338)
@@ -416,11 +416,14 @@
if ( !info || (info->type != SVC_HANDLE_IS_SCM) )
return WERR_BADFID;
- if ( !(info->access_granted & SC_RIGHT_MGR_ENUMERATE_SERVICE) )
+ if ( !(info->access_granted & SC_RIGHT_MGR_ENUMERATE_SERVICE) ) {
return WERR_ACCESS_DENIED;
+ }
- if ( (num_services = enumerate_status( p->mem_ctx, &services, token )) == -1 )
+ num_services = enumerate_status( p->mem_ctx, &services, token );
+ if (num_services == (uint32)-1 ) {
return WERR_NOMEM;
+ }
for ( i=0; i<num_services; i++ ) {
buffer_size += svcctl_sizeof_enum_services_status(&services[i]);
More information about the samba-cvs
mailing list