svn commit: samba r14320 - in trunk/source/passdb: .

[jmcd at samba.org]

Author: jmcd
Date: 2006-03-13 15:04:17 +0000 (Mon, 13 Mar 2006)
New Revision: 14320

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14320

Log:
Fix coverity #222: free storage before returning in error case.  This
error doesn't occur in 3.0.

Modified:
   trunk/source/passdb/pdb_ldap.c


Changeset:
Modified: trunk/source/passdb/pdb_ldap.c
===================================================================
--- trunk/source/passdb/pdb_ldap.c	2006-03-13 15:03:51 UTC (rev 14319)
+++ trunk/source/passdb/pdb_ldap.c	2006-03-13 15:04:17 UTC (rev 14320)
@@ -335,12 +335,12 @@
 	filter = talloc_asprintf(mem_ctx, "(&(uid=%s)(%s))",
 				 escape_user, get_objclass_filter_static(ldap_state->schema_ver));
 	
+	SAFE_FREE(escape_user);
+
 	if (filter == NULL) {
 		return LDAP_NO_MEMORY;
 	}
 
-	SAFE_FREE(escape_user);
-
 	return smbldap_search_suffix(ldap_state->smbldap_state, filter, attr, result);
 }