svn commit: samba r14276 - in trunk/source/nsswitch: .

jra at samba.org jra at samba.org
Mon Mar 13 01:08:35 GMT 2006


Author: jra
Date: 2006-03-13 01:08:34 +0000 (Mon, 13 Mar 2006)
New Revision: 14276

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14276

Log:
Shut-up coverity false positive (bug #199) by making an assertion
explicit.
Jeremy.

Modified:
   trunk/source/nsswitch/winbindd_pam.c


Changeset:
Modified: trunk/source/nsswitch/winbindd_pam.c
===================================================================
--- trunk/source/nsswitch/winbindd_pam.c	2006-03-13 01:08:27 UTC (rev 14275)
+++ trunk/source/nsswitch/winbindd_pam.c	2006-03-13 01:08:34 UTC (rev 14276)
@@ -1137,6 +1137,13 @@
 	
 		DOM_SID user_sid;
 
+		/* In all codepaths were result == NT_STATUS_OK info3 must have
+		   been initialized. */
+		if (!info3) {
+			result = NT_STATUS_INTERNAL_ERROR;
+			goto done;
+		}
+
 		netsamlogon_cache_store(name_user, info3);
 		wcache_invalidate_samlogon(find_domain_from_name(name_domain), info3);
 



More information about the samba-cvs mailing list