svn commit: samba r14273 - in branches/SAMBA_3_0/source/printing: .

jra at samba.org jra at samba.org
Mon Mar 13 00:37:58 GMT 2006


Author: jra
Date: 2006-03-13 00:37:57 +0000 (Mon, 13 Mar 2006)
New Revision: 14273

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14273

Log:
Fix coverity bug #202. Memory leak on error path.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/printing/nt_printing.c


Changeset:
Modified: branches/SAMBA_3_0/source/printing/nt_printing.c
===================================================================
--- branches/SAMBA_3_0/source/printing/nt_printing.c	2006-03-13 00:35:33 UTC (rev 14272)
+++ branches/SAMBA_3_0/source/printing/nt_printing.c	2006-03-13 00:37:57 UTC (rev 14273)
@@ -2804,8 +2804,10 @@
 	
 	/* return error if the key was not found */
 	
-	if ( i == data->num_keys )
+	if ( i == data->num_keys ) {
+		SAFE_FREE(subkeys_ptr);
 		return -1;
+	}
 	
 done:
 	/* tag off the end */



More information about the samba-cvs mailing list