svn commit: samba r14257 - in trunk/source/passdb: .

Jeremy Allison jra at samba.org
Mon Mar 13 00:32:11 GMT 2006


On Sun, Mar 12, 2006 at 07:22:18PM -0500, simo wrote:
> 
> Yes, I'm following the streams of patches. Do you know what I thought
> when I saw it?
> "That would not have happened if we had a talloc hierarchy".

A talloc hierarchy hung off random pointers is a poor man's C++ (IMHO).
It can be horribly misued. I'm wary of them at the moment.

> But I see you feel strongly (reading another reply while answering) ..
> in that case why not just make talloc_free check for context not being
> null itself instead of adding a really ugly (visually because of all
> caps) macro ? :-)

Consistency with the Samba4 talloc. It's the Samba3 style here, I'd
like to keep it consistent.

Jeremy.


More information about the samba-cvs mailing list