svn commit: samba r14257 - in trunk/source/passdb: .

simo idra at samba.org
Mon Mar 13 00:12:03 GMT 2006


On Sun, 2006-03-12 at 15:48 -0800, Jeremy Allison wrote:
> On Sun, Mar 12, 2006 at 11:09:32PM +0000, idra at samba.org wrote:
> > Author: idra
> > Date: 2006-03-12 23:09:31 +0000 (Sun, 12 Mar 2006)
> > New Revision: 14257
> > 
> > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14257
> > 
> > Log:
> > 
> > commit some fixes to the previous patch as Volker pointed out some flaws.
> 
> Still has problems. *Never* use talloc_free, always use TALLOC_FREE.
> If you're using talloc_free you need to be re-examining your
> patch.

no, the use of talloc_free() is ok because we are always sure the
context passed is not null and valid.

Only function misused talloc_free() and turned out that function should
not call any free at all as it does not own the memory context.
(thanks, your comment made me notice that while checking my statements
are indeed correct :)

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org



More information about the samba-cvs mailing list