svn commit: samba r14261 - in branches/SAMBA_3_0/source/libmsrpc: .

jra at samba.org jra at samba.org
Mon Mar 13 00:08:40 GMT 2006


Author: jra
Date: 2006-03-13 00:08:39 +0000 (Mon, 13 Mar 2006)
New Revision: 14261

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14261

Log:
Fix coverity #38. No null deref.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/libmsrpc/cac_winreg.c


Changeset:
Modified: branches/SAMBA_3_0/source/libmsrpc/cac_winreg.c
===================================================================
--- branches/SAMBA_3_0/source/libmsrpc/cac_winreg.c	2006-03-13 00:05:52 UTC (rev 14260)
+++ branches/SAMBA_3_0/source/libmsrpc/cac_winreg.c	2006-03-13 00:08:39 UTC (rev 14261)
@@ -960,6 +960,12 @@
       hnd->_internal.pipes[PI_SHUTDOWN] = True;
    }
 
+   pipe_hnd = cac_GetPipe(hnd, PI_SHUTDOWN);
+   if(!pipe_hnd) {
+      hnd->status = NT_STATUS_INVALID_HANDLE;
+      return CAC_FAILURE;
+   }
+
    msg = (op->in.message != NULL) ? op->in.message : talloc_strdup(mem_ctx, "");
 
    hnd->status = NT_STATUS_OK;



More information about the samba-cvs mailing list