svn commit: samba r14251 - in trunk/source/rpc_server: .

[jra at samba.org]

Author: jra
Date: 2006-03-12 19:16:57 +0000 (Sun, 12 Mar 2006)
New Revision: 14251

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14251

Log:
Fix coverity bug #107. Resource leak on error path.
Jeremy.

Modified:
   trunk/source/rpc_server/srv_spoolss_nt.c


Changeset:
Modified: trunk/source/rpc_server/srv_spoolss_nt.c
===================================================================
--- trunk/source/rpc_server/srv_spoolss_nt.c	2006-03-12 19:16:45 UTC (rev 14250)
+++ trunk/source/rpc_server/srv_spoolss_nt.c	2006-03-12 19:16:57 UTC (rev 14251)
@@ -4862,8 +4862,10 @@
 	if((printer=SMB_MALLOC_P(PRINTER_INFO_5))==NULL)
 		return WERR_NOMEM;
 
-	if (!construct_printer_info_5(print_hnd, printer, snum))
+	if (!construct_printer_info_5(print_hnd, printer, snum)) {
+		free_printer_info_5(printer);
 		return WERR_NOMEM;
+	}
 	
 	/* check the required size. */	
 	*needed += spoolss_size_printer_info_5(printer);