svn commit: samba r14244 - branches/SAMBA_3_0/source/rpc_client trunk/source/rpc_client

vlendec at samba.org vlendec at samba.org
Sun Mar 12 17:29:43 GMT 2006


Author: vlendec
Date: 2006-03-12 17:29:42 +0000 (Sun, 12 Mar 2006)
New Revision: 14244

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14244

Log:
Okay, had not seen that this happened twice.

Fix Coverity bug # 142.

Volker
Modified:
   branches/SAMBA_3_0/source/rpc_client/cli_spoolss.c
   trunk/source/rpc_client/cli_spoolss.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_client/cli_spoolss.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_client/cli_spoolss.c	2006-03-12 17:26:56 UTC (rev 14243)
+++ branches/SAMBA_3_0/source/rpc_client/cli_spoolss.c	2006-03-12 17:29:42 UTC (rev 14244)
@@ -338,7 +338,7 @@
 	uint32 i;
 
 	*jobs = TALLOC_ARRAY(mem_ctx, JOB_INFO_1, num_jobs);
-	if (!jobs) {
+	if (*jobs == NULL) {
 		return False;
 	}
 	prs_set_offset(&buffer->prs,0);

Modified: trunk/source/rpc_client/cli_spoolss.c
===================================================================
--- trunk/source/rpc_client/cli_spoolss.c	2006-03-12 17:26:56 UTC (rev 14243)
+++ trunk/source/rpc_client/cli_spoolss.c	2006-03-12 17:29:42 UTC (rev 14244)
@@ -338,7 +338,7 @@
 	uint32 i;
 
 	*jobs = TALLOC_ARRAY(mem_ctx, JOB_INFO_1, num_jobs);
-	if (!jobs) {
+	if (*jobs == NULL) {
 		return False;
 	}
 	prs_set_offset(&buffer->prs,0);



More information about the samba-cvs mailing list