svn commit: samba r14232 - branches/SAMBA_3_0/source/rpc_parse trunk/source/rpc_parse

vlendec at samba.org vlendec at samba.org
Sun Mar 12 10:44:20 GMT 2006


Author: vlendec
Date: 2006-03-12 10:44:19 +0000 (Sun, 12 Mar 2006)
New Revision: 14232

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14232

Log:
Fix Coverity Bug # 218
Modified:
   branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c
   trunk/source/rpc_parse/parse_spoolss.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c	2006-03-12 04:25:35 UTC (rev 14231)
+++ branches/SAMBA_3_0/source/rpc_parse/parse_spoolss.c	2006-03-12 10:44:19 UTC (rev 14232)
@@ -3740,7 +3740,7 @@
 
 	q_u->level = level;
 	q_u->info.level = level;
-	q_u->info.info_ptr = (info != NULL) ? 1 : 0;
+	q_u->info.info_ptr = 1;	/* Info is != NULL, see above */
 	switch (level) {
 
 	  /* There's no such thing as a setprinter level 1 */

Modified: trunk/source/rpc_parse/parse_spoolss.c
===================================================================
--- trunk/source/rpc_parse/parse_spoolss.c	2006-03-12 04:25:35 UTC (rev 14231)
+++ trunk/source/rpc_parse/parse_spoolss.c	2006-03-12 10:44:19 UTC (rev 14232)
@@ -3740,7 +3740,7 @@
 
 	q_u->level = level;
 	q_u->info.level = level;
-	q_u->info.info_ptr = (info != NULL) ? 1 : 0;
+	q_u->info.info_ptr = 1;	/* Info is != NULL, see above */
 	switch (level) {
 
 	  /* There's no such thing as a setprinter level 1 */



More information about the samba-cvs mailing list