svn commit: samba r14195 - in trunk/source/libmsrpc: .

jra at samba.org jra at samba.org
Sat Mar 11 02:43:39 GMT 2006


Author: jra
Date: 2006-03-11 02:43:34 +0000 (Sat, 11 Mar 2006)
New Revision: 14195

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14195

Log:
Coverity bug #35. Fix uninitialized pipe_hnd.
Jeremy.

Modified:
   trunk/source/libmsrpc/cac_winreg.c


Changeset:
Modified: trunk/source/libmsrpc/cac_winreg.c
===================================================================
--- trunk/source/libmsrpc/cac_winreg.c	2006-03-11 02:43:25 UTC (rev 14194)
+++ trunk/source/libmsrpc/cac_winreg.c	2006-03-11 02:43:34 UTC (rev 14195)
@@ -56,6 +56,12 @@
       hnd->_internal.pipes[PI_WINREG] = True;
    }
 
+   pipe_hnd = cac_GetPipe(hnd, PI_WINREG);
+   if(!pipe_hnd) {
+      hnd->status = NT_STATUS_INVALID_HANDLE;
+      return CAC_FAILURE;
+   }
+
    key = talloc(mem_ctx, POLICY_HND);
    if(!key) {
       hnd->status = NT_STATUS_NO_MEMORY;



More information about the samba-cvs mailing list