svn commit: samba r14176 - in branches/SAMBA_3_0/source/client: .

[jra at samba.org]

Author: jra
Date: 2006-03-10 23:22:38 +0000 (Fri, 10 Mar 2006)
New Revision: 14176

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14176

Log:
Fix coverity bug #30. Ensure no possible null deref.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/client/smbspool.c


Changeset:
Modified: branches/SAMBA_3_0/source/client/smbspool.c
===================================================================
--- branches/SAMBA_3_0/source/client/smbspool.c	2006-03-10 21:40:47 UTC (rev 14175)
+++ branches/SAMBA_3_0/source/client/smbspool.c	2006-03-10 23:22:38 UTC (rev 14176)
@@ -375,9 +375,14 @@
     return NULL;      
   }
     
-    
+  /* We pretty much guarentee password must be valid or a pointer
+     to a 0 char. */
+  if (!password) {
+    return NULL;
+  }
+  
   if ( (username) && (*username) && 
-      ((!password) || ((password) && (strlen(password) == 0 ))) && 
+      (strlen(password) == 0 ) && 
        (cli->use_kerberos) ) 
   {
     /* Use kerberos authentication */