svn commit: samba r14169 - in trunk/source/smbd: .

[jra at samba.org]

Author: jra
Date: 2006-03-10 17:52:52 +0000 (Fri, 10 Mar 2006)
New Revision: 14169

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14169

Log:
Fix Coverity #219. I think this is a false coverity
warning as it seems to get confused with assignment
and comparison. Clarify the code anyway.
Jeremy.

Modified:
   trunk/source/smbd/sesssetup.c


Changeset:
Modified: trunk/source/smbd/sesssetup.c
===================================================================
--- trunk/source/smbd/sesssetup.c	2006-03-10 17:52:41 UTC (rev 14168)
+++ trunk/source/smbd/sesssetup.c	2006-03-10 17:52:52 UTC (rev 14169)
@@ -1044,7 +1044,10 @@
 	} else {
 		struct auth_context *plaintext_auth_context = NULL;
 		const uint8 *chal;
-		if (NT_STATUS_IS_OK(nt_status = make_auth_context_subsystem(&plaintext_auth_context))) {
+
+		nt_status = make_auth_context_subsystem(&plaintext_auth_context);
+
+		if (NT_STATUS_IS_OK(nt_status)) {
 			chal = plaintext_auth_context->get_ntlm_challenge(plaintext_auth_context);
 			
 			if (!make_user_info_for_reply(&user_info,