svn commit: samba r14150 - branches/SAMBA_3_0/source/utils trunk/source/utils

[jmcd at samba.org]

Author: jmcd
Date: 2006-03-10 14:09:34 +0000 (Fri, 10 Mar 2006)
New Revision: 14150

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14150

Log:
Fix coverity #118: not freeing alloc'ed storage returned from
sstring_sub().

Modified:
   branches/SAMBA_3_0/source/utils/net_rpc_samsync.c
   trunk/source/utils/net_rpc_samsync.c


Changeset:
Modified: branches/SAMBA_3_0/source/utils/net_rpc_samsync.c
===================================================================
--- branches/SAMBA_3_0/source/utils/net_rpc_samsync.c	2006-03-10 13:38:17 UTC (rev 14149)
+++ branches/SAMBA_3_0/source/utils/net_rpc_samsync.c	2006-03-10 14:09:34 UTC (rev 14150)
@@ -1309,7 +1309,9 @@
 	fflush(add_fd);
 
 	/* Deallocate memory, and return */
-	if (suffix_attr != NULL) SAFE_FREE(suffix_attr);
+	SAFE_FREE(suffix_attr);
+	SAFE_FREE(user_attr);
+	SAFE_FREE(group_attr);
 	return NT_STATUS_OK;
 }
 

Modified: trunk/source/utils/net_rpc_samsync.c
===================================================================
--- trunk/source/utils/net_rpc_samsync.c	2006-03-10 13:38:17 UTC (rev 14149)
+++ trunk/source/utils/net_rpc_samsync.c	2006-03-10 14:09:34 UTC (rev 14150)
@@ -1309,7 +1309,9 @@
 	fflush(add_fd);
 
 	/* Deallocate memory, and return */
-	if (suffix_attr != NULL) SAFE_FREE(suffix_attr);
+	SAFE_FREE(suffix_attr);
+	SAFE_FREE(user_attr);
+	SAFE_FREE(group_attr);
 	return NT_STATUS_OK;
 }