svn commit: samba r14121 - in branches/SAMBA_3_0/source/rpc_client: .

jra at samba.org jra at samba.org
Thu Mar 9 23:20:53 GMT 2006


Author: jra
Date: 2006-03-09 23:20:52 +0000 (Thu, 09 Mar 2006)
New Revision: 14121

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14121

Log:
We never pass NULL to the rpc_api_pipe fn so don't
trigger coverity checks by testing for NULL.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/rpc_client/cli_pipe.c


Changeset:
Modified: branches/SAMBA_3_0/source/rpc_client/cli_pipe.c
===================================================================
--- branches/SAMBA_3_0/source/rpc_client/cli_pipe.c	2006-03-09 22:49:53 UTC (rev 14120)
+++ branches/SAMBA_3_0/source/rpc_client/cli_pipe.c	2006-03-09 23:20:52 UTC (rev 14121)
@@ -744,8 +744,8 @@
 	char *rparam = NULL;
 	uint32 rparam_len = 0;
 	uint16 setup[2];
-	char *pdata = data ? prs_data_p(data) : NULL;
-	uint32 data_len = data ? prs_offset(data) : 0;
+	char *pdata = prs_data_p(data);
+	uint32 data_len = prs_offset(data);
 	char *prdata = NULL;
 	uint32 rdata_len = 0;
 	uint32 max_data = cli->max_xmit_frag ? cli->max_xmit_frag : RPC_MAX_PDU_FRAG_LEN;



More information about the samba-cvs mailing list